Fix Matpower non regulating generators connected PV buses #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
geofjamg
changed the title
geofjamg
changed the title
geofjamg
changed the title
annetill
reviewed
Jul 10, 2023
| } | ||
| mGen.setVoltageMagnitudeSetpoint(targetVpu); | ||
| } else { | ||
| mGen.setVoltageMagnitudeSetpoint(0); |
There was a problem hiding this comment.
Are you sure you want to keep this zero value? Maybe the nominal voltage ?
There was a problem hiding this comment.
If you keep zero, can you add a comment for later ?
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
annetill
approved these changes
Jul 10, 2023
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
added a commit
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com> (cherry picked from commit 3ee9e8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When a non regulating generator is connected to a bus with an already voltage regulating generator, Matpower power flow failed.
What is the new behavior (if this is a feature change)?
This is because the voltage regulating status is at the bus level in Matpower format (field type) and it is not allowed to have a non regulating generator connected to a PV bus. In that case even with a zero voltageMagnitudeSetPoint, the power try to reach the voltage.
The solution is to convert this king of generator to a load.
Does this PR introduce a breaking change or deprecate an API?
Other information: