Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voltage angle limits API #2657

Merged
merged 57 commits into from
Sep 14, 2023
Merged

Voltage angle limits API #2657

merged 57 commits into from
Sep 14, 2023

Conversation

obrix
Copy link
Member

@obrix obrix commented Jul 27, 2023 •
edited by jeandemanged
Loading

This pull request is based on #2613 on suggest a modification of the API following discussion with @annetill .

VoltageAngleLimit has now a mandatory name, and optionnals low and high limit to abstract direction of flow.

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

marqueslanauja and others added 30 commits June 14, 2023 08:47
@marqueslanauja
VoltageAngleLimit
103625b 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into VoltageAngleLimits
4c7f665
@marqueslanauja
deterministic switchTerminalForVoltage. Add unitary test.
fbcfc5a 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Unitary test for voltageAngleLimit
a47b52f 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into VoltageAngleLimits
56183bc
@marqueslanauja
LimitViolation. Add unitary tests
0f31334 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
DefaultLimitViolationDetector. Add unitary tests
e3e3751 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
set subjectId to the id of the TerminalRef from
3346714 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
LimitViolations. More unitary tests
a02a374 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
More unitary tests. Minor changes.
2e767dc 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix mergingView
64d05b1 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
merge voltageAngleLimits
e87786d 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
merge tests
8599a9d 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
VoltageAngleLimit Xml
cc882d9 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
xml tests
01cbf70 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
More adder tests
ebd058c 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smells
fca5f9d 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smell
bf1af69 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@olperr1
Bump iidm xml version to 1.11
26c0e44 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@marqueslanauja
Merge branch 'main' into VoltageAngleLimits
5f620aa 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>

# Conflicts:
#	iidm/iidm-mergingview/src/main/java/com/powsybl/iidm/mergingview/MergingView.java
#	iidm/iidm-mergingview/src/main/java/com/powsybl/iidm/mergingview/MergingViewIndex.java
@annetill
Merge branch 'main' into xiidm_version_1_11
fff3df0
@marqueslanauja
Remove switches as TerminalRef
e9d2bca 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smell
e9fafee 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Reviewer comments
8cb0690 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@zamarrenolm
small refactor: move methods related to terminal ref
33f5153 
Signed-off-by: Luma <zamarrenolm@aia.es>
@marqueslanauja
Move code to TerminalRef class
29b958e 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@marqueslanauja
Fix code smell
3a5bff0 
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@zamarrenolm
Merge branch 'xiidm_version_1_11' into VoltageAngleLimits
41e0ff9
@zamarrenolm
bump xiidm version to 1.11 for voltage angle limit
827e207 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
from xiidm 1.11
d92d769 
Signed-off-by: Luma <zamarrenolm@aia.es>
annetill
annetill requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must know that:

  • We don't support three windings transformer in limit violations.
  • As the new voltage angle limit is not an identifier, the limit violation is a bit strange and rely on name only. We don't have a subjectId that is linked an identifier. To be validated with everybody.

...es-extensions/src/main/java/com/powsybl/cgmes/extensions/CgmesControlAreasXmlSerializer.java Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/Network.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/TerminalRef.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/VoltageAngleLimitAdderImpl.java Outdated Show resolved Hide resolved
@annetill annetill mentioned this pull request Sep 5, 2023
Closed
5 tasks
obrix added 3 commits September 6, 2023 11:30
@obrix
Expose Terminal instead of TerminalRef in VoltageAngleLimitAdder.
cacc3dd 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix
Remove TerminalRef.
ef7582f 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix
Update luma's comment.
d850cba 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
geofjamg
geofjamg requested changes Sep 11, 2023
View reviewed changes
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/TerminalUtil.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/TerminalUtil.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/TerminalUtil.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/TerminalUtil.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ThreeSides.java Show resolved Hide resolved
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/TerminalRefXml.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/TerminalUtil.java Outdated Show resolved Hide resolved
...-analysis/security-analysis-api/src/main/java/com/powsybl/security/LimitViolationHelper.java Outdated Show resolved Hide resolved
...-analysis/security-analysis-api/src/main/java/com/powsybl/security/LimitViolationHelper.java Outdated Show resolved Hide resolved
...nalysis-api/src/main/java/com/powsybl/security/detectors/AbstractLimitViolationDetector.java Outdated Show resolved Hide resolved
@obrix
Clean.
53aefef 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix
Replace name by id and ensure unicity.
f4965f7 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix
Move functions from TerminalUtil to Terminal.
2961bcd 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@jeandemanged jeandemanged changed the title Voltage angle limits API rework proposal Voltage angle limits API Sep 13, 2023
geofjamg and others added 4 commits September 14, 2023 09:45
@geofjamg
Clean
1679d84 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg
Clean
00d8439 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@obrix
Clean.
749db0f 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix
Reorder test on the list.
5e80eed 
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@flo-dup flo-dup force-pushed the evolution_xiidm/1.11 branch from dff0f7f to eea16e4 Compare September 14, 2023 09:36
Base automatically changed from evolution_xiidm/1.11 to main September 14, 2023 10:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.9% 87.9% Coverage
0.0% 0.0% Duplication

jeandemanged
jeandemanged approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you!

@annetill annetill merged commit 67216f4 into main Sep 14, 2023
6 checks passed
@annetill annetill deleted the VoltageAngleLimitsRework branch September 14, 2023 18:22
@annetill annetill mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamarrenolm zamarrenolm zamarrenolm left review comments

@annetill annetill annetill approved these changes

@jeandemanged jeandemanged jeandemanged approved these changes

@geofjamg geofjamg geofjamg approved these changes

Assignees
No one assigned
Labels
PR: next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@obrix @geofjamg @zamarrenolm @jeandemanged @annetill @marqueslanauja @olperr1 @EtienneLt