Check dense matrix max element count #2669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When we create large dense matrices we may encounter the maximum allowed size which is dependent of Java max integer value and unfortunately it silently fail because of an integer overflow. The buffer capacity is allowed without any error but with max integer value and later on we end up when setting element value to an index out of bound issue.
What is the new behavior (if this is a feature change)?
We throw an exception if the created dense matrix is too large.
Does this PR introduce a breaking change or deprecate an API?
Other information: