Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dense matrix max element count #2669

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Check dense matrix max element count #2669

merged 1 commit into from
Aug 11, 2023

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Aug 9, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When we create large dense matrices we may encounter the maximum allowed size which is dependent of Java max integer value and unfortunately it silently fail because of an integer overflow. The buffer capacity is allowed without any error but with max integer value and later on we end up when setting element value to an index out of bound issue.

What is the new behavior (if this is a feature change)?
We throw an exception if the created dense matrix is too large.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
@geofjamg geofjamg added the bug label Aug 9, 2023
@geofjamg geofjamg requested a review from olperr1 August 9, 2023 20:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@olperr1 olperr1 merged commit 579ac8b into main Aug 11, 2023
@olperr1 olperr1 deleted the dense_matrix_overflow branch August 11, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants