Rename dangling line ucteXnodeCode to pairingKey #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Perrin <44769592+olperr1@users.noreply.github.com> Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com> Co-authored-by: Anne Tilloy <48123713+annetill@users.noreply.github.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
flo-dup
force-pushed
the
evolution_xiidm/1.11
branch
from
dff0f7f to
eea16e4
Compare
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
annetill
reviewed
Sep 20, 2023
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/TieLineUtil.java
Outdated
Show resolved
Hide resolved
…ollowing merge Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
flo-dup
approved these changes
Sep 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Quality
What is the current behavior?
The attribute used to identify the dangling lines to merge together is called
ucteXnodeCode, which is disturbing for non-UCTE networks.What is the new behavior (if this is a feature change)?
The attribute used to identify the dangling lines to merge together is called
pairingKey.Does this PR introduce a breaking change or deprecate an API?
Other information:
For the migration guide:
The dangling line
ucteXnodeCodeattribute was renamed topairingKey. In consequence, some methods were also renamed as follows:DanglingLine.getUcteXnodeCode()->DanglingLine.getPairingKey()DanglingLineAdder.setUcteXnodeCode(String ucteXnodeCode)->DanglingLineAdder.setPairingKey(String pairingKey)TieLine.getUcteXnodeCode()->TieLine.getPairingKey()AbstractConductingEquipmentConversion.findUcteXnodeCode(...)->AbstractConductingEquipmentConversion.findPairingKey(...)