Remove dangling lines merge by ID #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olperr1
force-pushed
the
remove_dangling_lines_merge_by_id
branch
2 times, most recently
from
d6db0b0 to
8d1ae63
Compare
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
olperr1
force-pushed
the
remove_dangling_lines_merge_by_id
branch
from
8d1ae63 to
764b7b0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
When 2 dangling lines have the same id, if one or two of them don't have a
ucteXnodeCode, they are merged into a tie line during networks' merge.What is the new behavior (if this is a feature change)?
If 2 dangling lines have the same id, regardless of their
ucteXnodeCode, the networks' merge will fail.Does this PR introduce a breaking change or deprecate an API?
Other information: