Improve error message for lines between 2 Xnodes #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
annetill
reviewed
Aug 23, 2023
| @@ -457,7 +457,7 @@ private static void createLine(UcteNetworkExt ucteNetwork, Network network, | |||
| createDanglingLine(ucteLine, connected, xnode, nodeCode1, ucteVoltageLevel1, network); | |||
|
|
|||
| } else { | |||
| throw new UcteException("Line between 2 Xnodes"); | |||
| throw new UcteException("Line between 2 Xnodes: '" + nodeCode1 + "' and '" + nodeCode2 + "'"); | |||
There was a problem hiding this comment.
Just a detail but in the rest of the code, in error messages we write "X-node". I don't know what way is the good one.
There was a problem hiding this comment.
In UCTE import, I can see one "Xnode" and one "XNODE"
There was a problem hiding this comment.
What do you prefer? I will commit in your PR just a uniformisation if you don't mind.
There was a problem hiding this comment.
I replaced all by X-node
annetill
approved these changes
Aug 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Error message improvement
What is the current behavior?
When we have a line between 2 xnodes in a UCTE file, we get an error message but without the information of the 2 xnodes.
What is the new behavior (if this is a feature change)?
We have the name of the 2 xnodes.
Does this PR introduce a breaking change or deprecate an API?
Other information: