CGMES fix export SV: export phase and ratio tap changer if both present #2685

zamarrenolm · 2023-08-29T06:06:48Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

If a transformer has both phase and ratio tap changer, only the tap step for the phase tap changer is exported in the SV file. The SSH file correctly contains information about both tap changers.

What is the new behavior (if this is a feature change)?
Both tap steps are exported to the SV.

Does this PR introduce a breaking change or deprecate an API?

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Issue reported on slack cgmes channel by Kristjan Vilgo.

Signed-off-by: Luma <zamarrenolm@aia.es>

Signed-off-by: José Antonio Marqués <marquesja@aia.es>

annetill · 2023-09-07T09:35:58Z

...version/src/test/java/com/powsybl/cgmes/conversion/test/export/StateVariablesExportTest.java

+                .endStep()
+                .add();
+
+        // as all the tap positions are unique we check that RTC and PTC tap positions are in the sv file


It is just a unit test but the assertion are not really clean.

it was the simplest option to avoid re-importing the case and checking the tap position (costly in testing time), as the change in the code was very simple and only affected the SV output, but we will implement a more clear alternative.