Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGMES export SSH: allow update of control area, label as superseding #2699

Merged
merged 7 commits into from
Sep 19, 2023
Merged

CGMES export SSH: allow update of control area, label as superseding #2699

merged 7 commits into from
Sep 19, 2023

Conversation

zamarrenolm
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #2698

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@zamarrenolm
control area extension: allow update of netInterchange
03b3e9c 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
control area extension: add attribute pTolerance
3686351 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
remove hard-coded temp dir
78f798b 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
remove unused import
6e105e0 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm zamarrenolm self-assigned this Sep 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication

@zamarrenolm zamarrenolm marked this pull request as ready for review September 15, 2023 14:29
@annetill annetill merged commit 621bd28 into main Sep 19, 2023
@annetill annetill deleted the cgmes_export_ssh_updated_control_area_2698 branch September 19, 2023 13:45
marqueslanauja
marqueslanauja approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@marqueslanauja marqueslanauja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes and I did some tests. It is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill annetill approved these changes

@marqueslanauja marqueslanauja marqueslanauja approved these changes

Assignees

@zamarrenolm zamarrenolm

Labels
CGMES PR: next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CGMES export SSH : allow update of control area data and supersede previous file
3 participants
@zamarrenolm @annetill @marqueslanauja