Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect dangling lines disconnected at boundary #2730

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

zamarrenolm
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature

What is the current behavior?

When an equipment (ACLS, switch, 2w transformer, equivalent branch) located at boundary has the terminal at boundary side disconnected, the equivalent injection is set to zero, but there is not way to indicate that it should not be connected at boundary side.

This approach works for an individual grid model (IGM): leaving p0, q0 of dangling line set to zero when the boundary terminal is disconnected is electrically equivalent (a reactive injection at network side would be seen, if this side is connected).

But is creates a problem when the network is merged with another one: the tie line will be considered as connected.

What is the new behavior (if this is a feature change)?
To ensure a correct merging is made, we introduce a parameter (active by default) that forces the disconnection of the network side of dangling lines when its boundary terminals are disconnected. Calculation with the IGM introduces a (minor) approximation, but the merging will be more correct.

The parameter to control this behaviour is iidm.import.cgmes.disconnect-dangling-line-if-boundary-side-is-disconnected. It is true by default.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm zamarrenolm self-assigned this Oct 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.1% 91.1% Coverage
0.0% 0.0% Duplication

@@ -0,0 +1,286 @@
<?xml version="1.0" encoding="utf-8"?>
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:cim="http://iec.ch/TC57/2013/CIM-schema-cim16#" xmlns:entsoe="http://entsoe.eu/CIM/SchemaExtension/3/1#" xmlns:md="http://iec.ch/TC57/61970-552/ModelDescription/1#">
<md:FullModel rdf:about="urn:uuid:52b712d1-f3b0-4a59-9191-79f2fb1e4c4e">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an issue with CGMES conversion tests. The CI spends 20 minutes to run them. It seems that they are too big in general and more comparable to integration tests than to unit tests. We have to think about this issue with @flo-dup and maybe think about smallest network as we have the export now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an issue with CGMES conversion tests. The CI spends 20 minutes to run them. It seems that they are too big in general and more comparable to integration tests than to unit tests. We have to think about this issue with @flo-dup and maybe think about smallest network as we have the export now.

We will think about it, there are multiple alternatives: we either could "strip down" the test cases, removing the non-essential data, run all tests only on some builds/under a specific configuration, or move some of them to a separate repo.

@annetill annetill added the bug label Oct 3, 2023
@annetill annetill merged commit ebd1a6f into main Oct 4, 2023
6 checks passed
@annetill annetill deleted the cgmes_dangling_lines_disconnected_at_boundary branch October 4, 2023 07:09
olperr1 pushed a commit that referenced this pull request Oct 6, 2023
…2730)

Signed-off-by: Luma <zamarrenolm@aia.es>
(cherry picked from commit ebd1a6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants