Implement VoltageAngleLimit removal #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
approved these changes
Oct 6, 2023
| VoltageAngleLimit voltageAngleLimit = new VoltageAngleLimitImpl(id, from, to, lowLimit, highLimit); | ||
| VoltageLevelExt voltageLevel1 = (VoltageLevelExt) from.getVoltageLevel(); | ||
| VoltageLevelExt voltageLevel2 = (VoltageLevelExt) to.getVoltageLevel(); | ||
| Ref<NetworkImpl> networkRef = AbstractIdentifiableAdder.computeNetworkRef(network, voltageLevel1, voltageLevel2); |
There was a problem hiding this comment.
Strange to call this method from here, once again VoltageAngleLimit is very very close to an Identifiable...
olperr1
added a commit
that referenced
this pull request
Oct 6, 2023
* Implement VoltageAngleLimit removal * Use FourSubstationsNodeBreakerFactory in removal test * Fix code smells --------- Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com> (cherry picked from commit b3162cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Calling
remove()on aVoltageAngleLimitdoes nothing.What is the new behavior (if this is a feature change)?
Calling
remove()on aVoltageAngleLimitremoves it from its network.Does this PR introduce a breaking change or deprecate an API?
Other information: