Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VoltageAngleLimit retrieval by id from a subnetwork #2743

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented Oct 6, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

On a subnetwork n containing a VoltageAngleLimit which identifier is "id", n.getVoltageAngleLimit("id") returns null.

What is the new behavior (if this is a feature change)?
On a subnetwork n containing a VoltageAngleLimit which identifier is "id", n.getVoltageAngleLimit("id") returns the said VoltageAngleLimit.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 requested a review from flo-dup October 6, 2023 12:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@olperr1 olperr1 merged commit 965a415 into main Oct 6, 2023
6 checks passed
@olperr1 olperr1 deleted the fix_VoltageAngleLimit_retrieval_from_subnetwork branch October 6, 2023 12:58
olperr1 added a commit that referenced this pull request Oct 6, 2023
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
(cherry picked from commit 965a415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants