Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit reduction API #2760

Merged
merged 102 commits into from
Mar 18, 2024
Merged

Limit reduction API #2760

merged 102 commits into from
Mar 18, 2024

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Oct 29, 2023 •
edited by olperr1
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
#2751 : Limit Reduction Definition classes + (de)serialization

The computation of the reduced limits will be in another PR.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

SecurityAnalysisProvider.run(…) now takes an additional parameter: List<LimitReduction> limitReductions. You need to add this parameter to your own SecurityAnalysisProvider implementations.

Other information:

So-Fras and others added 21 commits October 25, 2023 16:28
@So-Fras
New ContingencyContext type
e17384a 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Creation of new classes
a359842 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Move contingency criterion in iidm-api module
a552c4e 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Move Criterion classes from contingency to iidm-api (2)
397beb0 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Other files affected by Criterion classes move
89d9e55 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
New duration and element criteria
2ad442e 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Add methods in LimitReductionDefinitionList
1b9ef73 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Add empty methods in new LimitViolationDetectorWithLimitReduction
385cc3b 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Remove some initializations with (not allowed) null parameters
bc50cc4 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Make constructor of abstract class protected instead of public
2cdeb5c 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Split temporary duration criterion classes in different files
29e4a4f 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Simplify criterion definition: no voltage or voltage angle limit redu…
894c2f3 
…ction considered

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Rename BranchCriterionType into NetworkElementCriterionType
69ef92a 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Remove last references to voltage or voltage angle limit
b73da03 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
WIP: add LimitReductionDefinition processing steps
ebad419 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Merge branch 'main' into limit_reduction
2845b1f
@So-Fras
Merge branch 'main' into limit_reduction
f420911
@So-Fras
Use ThreeSides instead of Branch.Side
9b5105d 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
First attempt for duration criterion filter and network element filter
7ef6b54 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Remove unused import
3380838 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras
Fix conflicts
dd08d29 
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@annetill annetill mentioned this pull request Dec 12, 2023
Open
@So-Fras
Use NetworkElementInterface instead of Identifiable for limit reducti…
728ef4a 
…on API

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

57.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@olperr1
Merge branch 'main' into limit_reduction
5958f29
@olperr1
Quality
1bb8a84 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Support null boundaries in IntervalTemporaryDurationCriterion + add u…
527455c 
…nit tests

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Rename NetworkElementInterface -> NetworkElement
51c76da 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Refactoring about NetworkElement
f4244ce 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
olperr1 and others added 4 commits March 12, 2024 14:51
@olperr1
Revert "Fix filters for tie lines" (will be put in a dedicated PR)
3a09878 
This reverts commit 165e67d.

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Restore new switch syntax in criterion classes
6b80ac4 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Add 'monitoringOnly' indicator to 'LimitReductionDefinition'
5dcd9a0 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@geofjamg
Merge branch 'main' into limit_reduction
8f41ad4
olperr1 added 12 commits March 13, 2024 17:45
@olperr1
Fix ...NominalVoltageCriterion classes regarding null nominal voltage
e9a7956 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Add EveryEquipmentCriterion
8a64b70 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Use a single ContingencyContext in LimitReductionDefinition instead o…
f760489 
…f a list

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Change LineCriterion and TieLineCriterion to use TWO_NOMINAL_VOLTAGE …
4a67b6f 
…criteria

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Fix serialization of TieLineCriterion and DanglingLineCriterion in Li…
6d5c6f2 
…mitReductionDefinition

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Rename old 'limitReduction' float to 'limitReductionValue' (except in…
d445265 
… powsybl-action-dsl module and in LimitViolation)

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Rename LimitReductionDefinition... to LimitReduction...
e6dc0c3 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Rename LimitReduction.limitReduction in LimitReduction.value
854b538 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Add missing equipment types to criterion classes
690b057 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Remove TODO
d70765a 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Use Optionals instead of null values for IntervalTemporaryDurationCri…
8c712ab 
…terion boundaries and NetworkElement fields

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1
Fix sonar issues
6f660de 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 mentioned this pull request Mar 18, 2024
Merged
7 tasks
annetill added 3 commits March 18, 2024 10:53
@annetill
Renaming.
423360b 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Fix unit test.
9d2f562 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Renaming (2).
cd8c125 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
annetill reviewed Mar 18, 2024
View reviewed changes
...iteria/src/main/java/com/powsybl/iidm/criteria/translation/DefaultNetworkElementAdapter.java
}

@Override
public boolean isValidFor(NetworkElementCriterionType type) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to understand what the method isValidFor is used for.

annetill
annetill approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this huge work, looks good to me. I will test it on powsybl-open-loadflow as soon as possible.

annetill and others added 2 commits March 18, 2024 12:40
@annetill
Merge branch 'main' into limit_reduction
c428fe4
@olperr1
Renaming (3).
dd86569 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarCloud

@annetill annetill changed the title Limit reduction API - Definition classes Limit reduction API Mar 18, 2024
@annetill annetill merged commit e539e11 into main Mar 18, 2024
6 checks passed
@annetill annetill deleted the limit_reduction branch March 18, 2024 14:02
rcourtier pushed a commit that referenced this pull request Mar 22, 2024
@So-Fras @olperr1 @rcourtier
Limit reduction API (#2760)
eb5072b 
- Limit reduction generic criteria
- Add limit reductions in security analysis API

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olperr1 olperr1 olperr1 left review comments

@EtienneLt EtienneLt EtienneLt left review comments

@geofjamg geofjamg geofjamg left review comments

@annetill annetill annetill approved these changes

Assignees

@olperr1 olperr1

@So-Fras So-Fras

Labels
Breaking Change API is broken March release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@So-Fras @geofjamg @EtienneLt @olperr1 @annetill