-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operational limits group #2802
Merged
Merged
Operational limits group #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pjeanmarie
force-pushed
the
add_operational_limits_set
branch
5 times, most recently
from
November 29, 2023 09:34
f321acc
to
f8829cd
Compare
annetill
reviewed
Dec 1, 2023
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/CurrentLimitsSet.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/OperationalLimitsSet.java
Outdated
Show resolved
Hide resolved
iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractCurrentLimitsTest.java
Outdated
Show resolved
Hide resolved
annetill
added
IIDM
Breaking Change
API is broken
new version XIIDM/JIIDM
and removed
IIDM
labels
Dec 1, 2023
annetill
changed the title
WIP: add currents limits set 1 for now, api and implem can be discuss
[WIP] Operational limit set
Dec 1, 2023
pjeanmarie
force-pushed
the
add_operational_limits_set
branch
from
December 19, 2023 14:55
2b72c1b
to
334ab50
Compare
pjeanmarie
force-pushed
the
add_operational_limits_set
branch
11 times, most recently
from
January 10, 2024 16:53
fe572fe
to
38323ac
Compare
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
pjeanmarie
force-pushed
the
add_operational_limits_set
branch
from
January 16, 2024 11:47
2bf6764
to
104fbf2
Compare
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
- Fix typo in getter - Various minor fixes - Remove duplicate adders - Fix random order - Replace list with collection - Use interface instead of impl and fix method names - Fix serialization - Add ownerId in AbstractLoadingLimitsAdder constructor - Fix serde unit tests - Fix network modifications unit test references - Fix matpower unit test reference Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
olperr1
requested changes
Jan 18, 2024
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/OperationalLimitsGroupsImpl.java
Outdated
Show resolved
Hide resolved
…n is cancelled Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Allows to centralize the selectedGroupId update Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
olperr1
approved these changes
Jan 19, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #2110
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Operational limits serialization in IIDM v1.12
For each network element side:
Instead of having objects for
currentLimits
,activePowerLimits
andapparentPowerLimits
directly on the network element, they are grouped together in anoperationalLimitsGroup
object which have an ID.There can be several
operationalLimitsGroup
objects but only one is used for limit violations detection. The ID of this "selected" OperationLimitsGroup is indicated by an attribute of the network element.Example in IIDM
Before (IIDM 1.11):
After (IIDM 1.12):
Operational limits are grouped by side in 2 objects
operationalLimitsGroup1
(for side 1) andoperationalLimitsGroup2
(for side 2). Here, both groups are called with the default idDEFAULT
. They are defined as the selected group on both sides with the attributesselectedOperationalLimitsGroupId1="DEFAULT" selectedOperationalLimitsGroupId2="DEFAULT"
.When there are several groups for a side n, they are listed using several
operationalLimitsGroup
n objects. For instance, if a line has the operational limit groupsA
andB
on side 1 and the groupsG1
andG2
on side two, the XIIDM will look like:For custom IIDM implementations maintainers
If you have defined your own IIDM implementation, you should:
implement the
OperationalLimitGroup
interface;in your
Branch
implementations:in your
TieLine
andThreeWindingsTransformer.Leg
implementations:Other information: