Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify CGMES naming strategy so that the IDs are stable #2804

Merged
merged 66 commits into from
Jan 15, 2024
Merged

Modify CGMES naming strategy so that the IDs are stable #2804

merged 66 commits into from
Jan 15, 2024

Conversation

colinepiloquet
Copy link
Member

@colinepiloquet colinepiloquet commented Nov 28, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Work in progress related to #2783, also remove the generation of the id mapping csv and reading the ids from a csv.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

colinepiloquet and others added 4 commits November 28, 2023 12:05
@colinepiloquet
Add namespace in UUID generation
c664e5d 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
change way to generate uuid
f4a7315 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@zamarrenolm
merge main, solve conflicts
a6478a5 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
update number of params in exporter
434d25e 
Signed-off-by: Luma <zamarrenolm@aia.es>
@annetill annetill added the CGMES label Dec 1, 2023
@zamarrenolm
by default do not use namespace for stable UUID unique ids based on n…
7225758 
…ames

Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
Merge branch 'main' into cgmes_naming_strategy
baecdf6
@zamarrenolm
naming strategy keeps uuid namespace
4dc594f 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
Merge branch 'main' into cgmes_naming_strategy
4294f2a
@zamarrenolm
type of uuid namespace is UUID
7aa5088 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
remove mapping file
9564dee 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
temporary check unit tests using random UUIDs
3fd5d22 
Signed-off-by: Luma <zamarrenolm@aia.es>
zamarrenolm and others added 17 commits December 5, 2023 15:36
@zamarrenolm
Merge branch 'main' into cgmes_naming_strategy
e1a9b1f
@colinepiloquet
Start implementing specific seed creation for UUID generation
2bcd91e 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Fixes
3ab1d31 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Improve limits ID generation.
aa95b11 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Improve tap changers ID generation
b0db66a 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Improve nodes ID generation
7716b08 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Modify remaining strings in getUniqueId
25a7ca9 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Fix bug
d6b4821 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@zamarrenolm
fix unit test
b03e023 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
comment
15b8f40 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
separate suffixes for RC of ratio and phase tap changers
778fcc1 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
activate name-based uuids
09b24a1 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
fix suffix for the terminal of the equivalent injection
2adbb2b 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
Merge branch 'main' into cgmes_naming_strategy
2027e3c
@zamarrenolm
use random uuids for Sv objects (they are not persistent)
236c038 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
unique ids are provided by the naming strategy
cc9cb2e 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
fix calls to unique ids in missing containers preprocessor
1b051e4 
Signed-off-by: Luma <zamarrenolm@aia.es>
zamarrenolm and others added 18 commits December 21, 2023 11:26
@zamarrenolm
sometimes we do not need to add the suffix for the identifiable type
be06706 
Signed-off-by: Luma <zamarrenolm@aia.es>
@colinepiloquet
Fix refGeneratingUnit + remove useless reference to AC Line Segment
65f2b17 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@zamarrenolm
cleanup: uniform method name, avoid multiple calls to unique id with …
6f7853b 
…same seed

Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
cleanup: remove unused naming conversion of geo tag
5c29116 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
cleanup: debug
ffb7c0d 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
cleanup: remove obsolete methods
4bba6dd 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
minor fixes after testing against real-world cases
b5a16c4 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
consistent dc topological nodes
6d51fba 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
consistent dc topological nodes
0096fea 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
code cleanup; get rid of old mechanism for storing uuids read from ma…
c25a200 
…pping file

Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
always use name-based uuids
6a4cf78 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
fix sonar issues
7be424b 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
remove potential urn:uuid prefix from ids before using them
47669fc 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm
fix sonar issues
65d6dd2 
Signed-off-by: Luma <zamarrenolm@aia.es>
@annetill
Merge branch 'main' into cgmes_naming_strategy
edae45c
@zamarrenolm
Merge branch 'main' into cgmes_naming_strategy
4d48d14
@colinepiloquet
A few fixes to make it work on my usecase
020556f 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Add condition in debug that should not have been removed
588c404 
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet
colinepiloquet commented Jan 11, 2024
View reviewed changes
...mpletion/src/main/java/com/powsybl/cgmes/completion/CreateMissingContainersPreProcessor.java
@@ -71,7 +74,7 @@ public class CreateMissingContainersPreProcessor implements CgmesImportPreProces

public static final String NAME = "createMissingContainers";
public static final String FIXES_FOLDER_NAME = "iidm.import.cgmes.fixes-for-missing-containers-folder";
public static final double DEFAULT_NOMINAL_VALUE_FOR_MISSING_VOLTAGE_LEVELS = 100.0;
public static final double DEFAULT_NOMINAL_VALUE_FOR_MISSING_VOLTAGE_LEVELS = 1.2345;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change?

Copy link
Member

@zamarrenolm zamarrenolm Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do NOT want to use a valid, reasonable nominal voltage that could be defined in reference data. We want to express that we do not have information about this nominal voltage.

@colinepiloquet colinepiloquet changed the title [WIP] Modify CGMES naming strategy so that the IDs are stable Modify CGMES naming strategy so that the IDs are stable Jan 11, 2024
annetill
annetill approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this huge work, it works perfectly on our french network.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
81.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@annetill annetill merged commit ad44c8f into main Jan 15, 2024
6 checks passed
@annetill annetill deleted the cgmes_naming_strategy branch January 15, 2024 15:03
@zamarrenolm zamarrenolm mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamarrenolm zamarrenolm zamarrenolm left review comments

@annetill annetill annetill approved these changes

Assignees
No one assigned
Labels
CGMES January release PR: ready-to-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinepiloquet @zamarrenolm @annetill