Precise error and log messages for extensions #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
rolnico
changed the title
…nt tests Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
geofjamg
reviewed
Dec 7, 2023
| @@ -77,6 +77,16 @@ | |||
| </dependency> | |||
|
|
|||
| <!-- Test dependencies --> | |||
| <dependency> | |||
There was a problem hiding this comment.
We usually prefer to use slf4j-simple in unit tests
There was a problem hiding this comment.
I know but to test log messages, slf4j-simple is not enough
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
olperr1
requested changes
Dec 11, 2023
.../iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/ReferencePriorityImpl.java
Outdated
Show resolved
Hide resolved
...k/src/test/java/com/powsybl/iidm/network/tck/extensions/AbstractReferencePrioritiesTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
olperr1
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #2822
Does this PR introduce a breaking change or deprecate an API?
Other information: