Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the tap changer adder interfaces #2828

Merged
merged 15 commits into from
Jan 11, 2024
Merged

Refactor the tap changer adder interfaces #2828

merged 15 commits into from
Jan 11, 2024

Conversation

flomillot
Copy link
Contributor

@flomillot flomillot commented Dec 6, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Refactoring RatioTapChangerAdder and PhaseTapChangerAdder by creating a new common interface TapChangerAdder and doing the same for their StepAdder.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)
If using the interfaces PhaseTapChangerAdder.StepAdder and RatioTapChangerAdder.StepAdder, you need to replace them by PhaseTapChangerStepAdder and RatioTapChangerStepAdder.

@flomillot
Refactor the tap changer adder interfaces
ea06913 
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
@flomillot
Clean code
2c67339 
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
@flomillot
checkstyle
7cda324 
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
@flomillot
Fix new interface
74aa317 
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
@flomillot flomillot force-pushed the refactor_tap_changer_adder_interfaces branch from e7aecd1 to 74aa317 Compare December 7, 2023 09:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@flomillot flomillot added the Breaking Change API is broken label Dec 15, 2023
@annetill annetill requested a review from flo-dup December 18, 2023 08:43
@annetill annetill requested a review from olperr1 January 3, 2024 08:33
flomillot and others added 5 commits January 10, 2024 10:54
@flomillot @olperr1
Update iidm/iidm-api/src/main/java/com/powsybl/iidm/network/PhaseTapC…
3f9cf9d 
…hangerStepAdder.java

Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@flomillot @olperr1
Update iidm/iidm-api/src/main/java/com/powsybl/iidm/network/RatioTapC…
c09d27c 
…hangerStepAdder.java

Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@flomillot @olperr1
Update iidm/iidm-api/src/main/java/com/powsybl/iidm/network/TapChange…
61d4624 
…rStepAdder.java

Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@flomillot @olperr1
Update iidm/iidm-api/src/main/java/com/powsybl/iidm/network/TapChange…
8673bc4 
…rAdder.java

Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@flomillot @olperr1
Update iidm/iidm-api/src/main/java/com/powsybl/iidm/network/TapChange…
bbb75a4 
…rStepAdder.java

Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@flomillot flomillot requested a review from olperr1 January 10, 2024 09:57
@olperr1
Copy link
Member

olperr1 commented Jan 10, 2024

@flomillot: Today, we merged a PR (#2758) introducing a regulation mode on RatioTapChanger (this explains the conflict currently reported on this PR).
Could you see if it is possible/reasonable to share the methods concerning it in TapChangerAdder?

@flomillot
Merge remote-tracking branch 'origin/main' into refactor_tap_changer_…
40f7c46 
…adder_interfaces

# Conflicts:
#	iidm/iidm-api/src/main/java/com/powsybl/iidm/network/RatioTapChangerAdder.java
@flomillot
Copy link
Contributor Author

@flomillot: Today, we merged a PR (#2758) introducing a regulation mode on RatioTapChanger (this explains the conflict currently reported on this PR). Could you see if it is possible/reasonable to share the methods concerning it in TapChangerAdder?

Yes but actually in the PR it's not even shared in TapChanger, I guess I have to do it also ?

@flomillot
Fix merge
a187778 
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
@olperr1
Copy link
Member

olperr1 commented Jan 11, 2024

@flomillot: Today, we merged a PR (#2758) introducing a regulation mode on RatioTapChanger (this explains the conflict currently reported on this PR). Could you see if it is possible/reasonable to share the methods concerning it in TapChangerAdder?

Yes but actually in the PR it's not even shared in TapChanger, I guess I have to do it also ?

@flomillot : Ok, you are right. I propose to keep it like this for now.

flo-dup and others added 3 commits January 11, 2024 16:14
@flo-dup
Use new factorization in deserialization
e000790 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Merge branch 'main' into refactor_tap_changer_adder_interfaces
5401964
@flo-dup
Fix code smell: remove unused interface
5d7b626 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@flo-dup flo-dup merged commit 450d65d into main Jan 11, 2024
6 checks passed
@flo-dup flo-dup deleted the refactor_tap_changer_adder_interfaces branch January 11, 2024 15:58
@olperr1 olperr1 mentioned this pull request Jan 16, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

@olperr1 olperr1 olperr1 approved these changes

@etiennehomer etiennehomer etiennehomer approved these changes

Assignees
No one assigned
Labels
Breaking Change API is broken January release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flomillot @olperr1 @etiennehomer @flo-dup @annetill