[CGMES export] New business process parameter #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinepiloquet
commented
Feb 5, 2024
...s/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/CgmesExportContext.java
Outdated
Show resolved
Hide resolved
|
For me it is ok to keep the business process inside the export context. |
|
It is not easy to test except by using the check on the UUIDs #2888 |
colinepiloquet
requested review from
zamarrenolm and
annetill
and removed request for
zamarrenolm
zamarrenolm
approved these changes
Feb 6, 2024
…llModel Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet
force-pushed
the
add_business_process_parameter
branch
from
25af6d1 to
0dab0aa
Compare
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
|
zamarrenolm
changed the title
olperr1
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Add new parameter for business process to generate a unique ID for FullModel Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com> * Add test and change where business process is Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com> * Add test Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com> * Fix testExporter Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com> * expand unit test to check for uniqueness Signed-off-by: Luma <zamarrenolm@aia.es> * constant for default modeling authority set Signed-off-by: Luma <zamarrenolm@aia.es> * add unit test, allow boundaries placed in config filesystem Signed-off-by: Luma <zamarrenolm@aia.es> * fix sonar issues Signed-off-by: Luma <zamarrenolm@aia.es> --------- Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com> Signed-off-by: Luma <zamarrenolm@aia.es> Co-authored-by: Luma <zamarrenolm@aia.es> (cherry picked from commit f8e9013)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix: the ID of the EQ, TP, SSH and SV FullModel should be unique, this implies adding business process in the string used to generate the UUID.
What is the current behavior?
Business process parameter does not exist, ID is not unique.
What is the new behavior (if this is a feature change)?
ID is not unique yet but it completes PR #2888.
Does this PR introduce a breaking change or deprecate an API?