Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES. UUIDs with a leading underscore are considered valid master resource ids #2896

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

zamarrenolm
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

The issue was raised when exporting an updated SSH of an IIDM network that had valid UUID in its identifiables, but prefixed with an underscore. When the SSH was exported using the cgmes naming strategy, these prefixed identifiers were considered not valid and "fixed": replaced by newly created ones. This meant that the references to the original objects in the CGMES EQ instance file were lost.

What is the new behavior (if this is a feature change)?
UUIDs with a leading "_" character are considered valid Master Resource Identifiers.
A specific unit test to check the scenario where the issue was first raised has been added.

…source ids

Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Copy link

sonarqubecloud bot commented Feb 9, 2024

@annetill annetill merged commit d6c8cfe into main Feb 9, 2024
6 checks passed
@annetill annetill deleted the cgmes_valid_mrid_leading_underscore branch February 9, 2024 15:29
olperr1 pushed a commit that referenced this pull request Feb 15, 2024
…ster resource ids (#2896)

Signed-off-by: Luma <zamarrenolm@aia.es>
(cherry picked from commit d6c8cfe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants