Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES. Fix performance regression checking for condensers #2933

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

zamarrenolm
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

The query that selects synchronous machines that are not condensers takes too long to complete on real world models.
The performance of the check FILTER (!REGEX(STR(?type), "Kind.condenser")) is very poor.

What is the new behavior (if this is a feature change)?
To select all synchronous machines that can act as generators, we have replaced the check for an explicit list of allowed values:

VALUES ?type {
    cim:SynchronousMachineKind.generator
    cim:SynchronousMachineKind.generatorOrCondenser
    cim:SynchronousMachineKind.motor
    cim:SynchronousMachineKind.generatorOrMotor
    cim:SynchronousMachineKind.motorOrCondenser
    cim:SynchronousMachineKind.generatorOrMotorOrCondenser
}

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: Luma <zamarrenolm@aia.es>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@annetill annetill merged commit 9df658f into main Mar 15, 2024
6 checks passed
@annetill annetill deleted the cgmes_fix_performance_regression_condensers branch March 15, 2024 11:56
olperr1 pushed a commit that referenced this pull request Mar 25, 2024
Signed-off-by: Luma <zamarrenolm@aia.es>
(cherry picked from commit 9df658f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants