You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check if the PR fulfills these requirements
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
What is the current behavior?
The original psse records are updated before exporting them.
What is the new behavior (if this is a feature change)?
Original psse records are always preserved. A partial copy, only the updated record groups are copied, is made before updating them.
Does this PR introduce a breaking change or deprecate an API?
Yes
No
If yes, please check if the following requirements are fulfilled
The Breaking Change or Deprecated label has been added
The migration steps are described in the following section
What changes might users need to make in their application due to this PR? (migration steps)
I think it would be better to deep copy all the record groups when preparing the updated data, instead of deep copy some of them and keeping references for others. If later we have to make updates in a record group that is only saved as a reference we have to remember to make the deep copy first.
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
# Conflicts:
# psse/psse-converter/src/test/java/com/powsybl/psse/converter/PsseExporterTest.java
I think it would be better to deep copy all the record groups when preparing the updated data, instead of deep copy some of them and keeping references for others. If later we have to make updates in a record group that is only saved as a reference we have to remember to make the deep copy first.
I think it would be better to deep copy all the record groups when preparing the updated data, instead of deep copy some of them and keeping references for others. If later we have to make updates in a record group that is only saved as a reference we have to remember to make the deep copy first.
We can think about it.
This is true that it would be maybe more robust to deep copy everything but let's do it later in another PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…copy)
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Feature
What is the current behavior?
The original psse records are updated before exporting them.
What is the new behavior (if this is a feature change)?
Original psse records are always preserved. A partial copy, only the updated record groups are copied, is made before updating them.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: