Add a new identifier with wildcards support #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneLt
changed the title
|
forgot a test for serialization/deserialization |
olperr1
requested changes
Apr 22, 2024
...rc/main/java/com/powsybl/iidm/network/identifiers/ElementWithUnknownCharacterIdentifier.java
Outdated
Show resolved
Hide resolved
...cy-api/src/main/java/com/powsybl/contingency/contingency/list/IdentifierContingencyList.java
Outdated
Show resolved
Hide resolved
.../test/java/com/powsybl/contingency/json/NetworkElementIdentifierContingencyListJsonTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/network/identifiers/ElementWithUnknownCharacterIdentifier.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/network/identifiers/ElementWithUnknownCharacterIdentifier.java
Outdated
Show resolved
Hide resolved
...y-api/src/test/java/com/powsybl/contingency/NetworkElementIdentifierContingencyListTest.java
Show resolved
Hide resolved
...y-api/src/test/java/com/powsybl/contingency/NetworkElementIdentifierContingencyListTest.java
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/network/identifiers/ElementWithUnknownCharacterIdentifier.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/network/identifiers/ElementWithUnknownCharacterIdentifier.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/network/identifiers/ElementWithUnknownCharacterIdentifier.java
Outdated
Show resolved
Hide resolved
olperr1
changed the title
olperr1
changed the title
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
EtienneLt
force-pushed
the
add-new-identifier-for-unknown-number-element
branch
from
aae3516 to
6674215
Compare
olperr1
requested changes
Apr 24, 2024
.../main/java/com/powsybl/iidm/network/identifiers/IdWithWildcardsNetworkElementIdentifier.java
Outdated
Show resolved
Hide resolved
...y-api/src/test/java/com/powsybl/contingency/NetworkElementIdentifierContingencyListTest.java
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
olperr1
requested changes
May 14, 2024
.../main/java/com/powsybl/iidm/network/identifiers/IdWithWildcardsNetworkElementIdentifier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
olperr1
approved these changes
May 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the new behavior (if this is a feature change)?
it adds a new identifier to identify some network elements which has one or more unknown character in his id
Does this PR introduce a breaking change or deprecate an API?