Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an IIDM import post-processor to fill geographical extensions from ODRE data #2998

Merged
merged 42 commits into from
May 31, 2024
Merged

Add an IIDM import post-processor to fill geographical extensions from ODRE data #2998

merged 42 commits into from
May 31, 2024

Conversation

HugoKulesza
Copy link
Contributor

@HugoKulesza HugoKulesza commented May 2, 2024 •
edited by olperr1
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

This PR adds a new ImportPostProcessor that can be used to add geographical data of substations and lines to IIDM network automaticly at the import.
To get the information needed, it uses CSV files that are formatted like the ones that can be obtained on OpenData Réseaux-Energies website for RTE network.

See the documentation: https://powsybl.readthedocs.io/projects/powsybl-core/en/v6.4.0-rc1/grid_features/import_post_processor.html#geographical-data-import-post-processor

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

HugoKulesza and others added 13 commits March 27, 2024 15:45
@HugoKulesza
Add module to load positions on a network using ODRE csv files
5cd3fb1 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
setting geodata using an import postprocessor
fdca677 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
Merge branch 'main' into geodata
5765576
@HugoKulesza
fix checkstyle
ca95e64 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
fix powsybl version
9b601e0 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
adding package to distribution
25fc769 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
adding tests
786cbdc 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
add tests
9cc4786 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
fix style + add multiple coordinate components line
a1e37e2 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
add test with valid line name
dee125d 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
wrong path
8b178af 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
set right Test import
19cac42 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
adding all work coming from rte-core
8636204 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza HugoKulesza self-assigned this May 2, 2024
HugoKulesza and others added 5 commits May 2, 2024 12:59
@HugoKulesza
fix javadoc for authors
3c410b2 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
fix smells
e20f1da 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
add coverage + license
0a39f91 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
fix smell
e0d3b67 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
Merge branch 'main' into geodata
a23ba6b
@HugoKulesza HugoKulesza requested a review from jonenst May 7, 2024 13:27
HugoKulesza and others added 2 commits May 13, 2024 15:02
@HugoKulesza
fix get elements
61a8f35 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
Merge branch 'main' into geodata
954997d
@HugoKulesza HugoKulesza requested a review from jonenst May 13, 2024 13:27
olperr1 and others added 3 commits May 14, 2024 14:21
@olperr1
Fix groupId in pom.xml
a50e5fa 
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@HugoKulesza
rework copyright dates
0e33b62 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
add spdx to pom
e4200e3 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
olperr1
olperr1 requested changes May 22, 2024
View reviewed changes
Copy link
Member

@olperr1 olperr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to distinguish the generic classes from the ODRE-dependent ones.

The following classes could be shared:

  • the 3 classes of the dto package;
  • in the utils package:
    • DistanceCalculator;
    • GeoShapeDeserializer;
    • InputUtils;
    • LineGraph.
  • OdreGeoDataAdder could be split in 2: the 2 first methods could be shared, while the 2 others are really ODRE-dependent.

Could you introduce an odre subpackage to isolate ODRE-dependent classes and let the other in their current package?

HugoKulesza and others added 5 commits May 24, 2024 09:15
@HugoKulesza
separate specific odre and general utility methods and classes
7e97c32 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
Merge branch 'main' into geodata
f40b159
@HugoKulesza
remove smell
7721c85 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
Merge branch 'main' into geodata
795c2dd
@HugoKulesza
adding geographical data documentation
499952a 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
olperr1
olperr1 requested changes May 29, 2024
View reviewed changes
iidm/pom.xml Show resolved Hide resolved
docs/geographical_data.md Outdated Show resolved Hide resolved
iidm/iidm-geodata/src/main/java/com/powsybl/iidm/geodata/odre/FileValidator.java Outdated Show resolved Hide resolved
iidm/iidm-geodata/src/main/java/com/powsybl/iidm/geodata/odre/FileValidator.java Outdated Show resolved Hide resolved
docs/geographical_data.md Outdated Show resolved Hide resolved
docs/geographical_data.md Outdated Show resolved Hide resolved
docs/geographical_data.md Outdated Show resolved Hide resolved
.../iidm-geodata/src/main/java/com/powsybl/iidm/geodata/odre/OdreGeoDataAdderPostProcessor.java Outdated Show resolved Hide resolved
@HugoKulesza
fix typo + links
f8fff20 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
olperr1
olperr1 requested changes May 30, 2024
View reviewed changes
docs/geographical_data.md Outdated Show resolved Hide resolved
docs/geographical_data.md Outdated Show resolved Hide resolved
HugoKulesza and others added 5 commits May 30, 2024 14:55
@HugoKulesza
Merge branch 'main' into geodata
597c79f
@HugoKulesza
move odreGeoDataImporter doc to import_post_processor
28d6049 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@HugoKulesza
Merge branch 'main' into geodata
9e5b6f7
@HugoKulesza
move position extensions to extensions.md
a99b81f 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@olperr1
Fix post-processor module name in the documentation + ODRE license me…
20f3aa0 
…ssage

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@HugoKulesza
renaming dto package to elements
a42b849 
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@olperr1 olperr1 merged commit 1af008c into main May 31, 2024
7 checks passed
@olperr1 olperr1 deleted the geodata branch May 31, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olperr1 olperr1 olperr1 approved these changes

@jonenst jonenst jonenst approved these changes

Assignees

@HugoKulesza HugoKulesza

Labels
June release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HugoKulesza @jonenst @olperr1 @annetill