Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three-windings transformer manipulation improvements #3014

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Conversation

annetill
Copy link
Member

@annetill annetill commented May 15, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No. But convenient methods for three windings transformer management is missing.

What kind of change does this PR introduce?

  • Get the transformer from a leg.
  • Use ThreeSide in ThreeWindingsTransformerToBeEstimated extension.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

In ThreeWindingsTransformer.Leg interface, each implementations must add a getTransformer() method that gives the transformer associated to a leg.
In ThreeWindingsTransformerToBeEstimatedAdder, two new methods must be implemented:

  • withRatioTapChangerStatus(ThreeSides side, boolean toBeEstimated) and
  • withPhaseTapChangerStatus(ThreeSides side, boolean toBeEstimated).

Other information:

annetill added 2 commits May 14, 2024 09:57
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title [WIP] Three-windings transformer manipulation improvements Three-windings transformer manipulation improvements Jun 5, 2024
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Copy link

sonarqubecloud bot commented Jun 5, 2024

@annetill annetill added the Breaking Change API is broken label Jun 5, 2024
Copy link
Member

@rolnico rolnico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flo-dup flo-dup merged commit a4f113e into main Jun 5, 2024
6 checks passed
@flo-dup flo-dup deleted the t3w-improvement branch June 5, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants