Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove order constraint for streams in tck #3020

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

AbdelHedhili
Copy link
Member

@AbdelHedhili AbdelHedhili commented May 16, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Modify TCK test

What is the current behavior?
When retrieving equipment from a network with streams we check for a specific order in the TCK.

What is the new behavior (if this is a feature change)?
Only check that the content is the same, we don't care about the order

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Custom IIDM implementation maintainers should add the following dependency in their TCK implementation's pom.xml:

<dependency>
    <groupId>org.assertj</groupId>
    <artifactId>assertj-core</artifactId>
    <scope>test</scope>
</dependency>

Other information:

Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili AbdelHedhili self-assigned this May 16, 2024
@AbdelHedhili AbdelHedhili requested a review from olperr1 May 16, 2024 13:08
@AbdelHedhili AbdelHedhili requested a review from olperr1 May 22, 2024 07:57
@olperr1 olperr1 added the Breaking Change API is broken label May 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@olperr1 olperr1 merged commit 2b73dc7 into main May 22, 2024
6 checks passed
@olperr1 olperr1 deleted the release_order_constraint branch May 22, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants