TCK: Remove reference comparisons for CurrentLimits #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
AbdelHedhili
force-pushed
the
remove_ref_comparison_currentLimits
branch
from
2ff423b to
c3cc050
Compare
rolnico
requested changes
May 22, 2024
iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractLineTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
rolnico
approved these changes
May 24, 2024
olperr1
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
changes TCK test
What is the current behavior?
There are tests that compare currentLimits by reference and expect that we keep the same reference for these objects
What is the new behavior (if this is a feature change)?
Remove these checks that are implementation dependent
Does this PR introduce a breaking change or deprecate an API?