Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize PhaseTapChangerAdderImpl and RatioTapChangerAdderImpl #3033

Merged
merged 3 commits into from
May 24, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented May 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Factorization

What is the current behavior?
PhaseTapChangerAdderImpl and RatioTapChangerAdderImpl contain duplicate code

What is the new behavior (if this is a feature change)?
Duplicate code is factorized in an AbstractTapChangerAdderImpl

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

flo-dup added 2 commits May 24, 2024 12:59
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from olperr1 May 24, 2024 13:02
Copy link

@flo-dup flo-dup merged commit ba9cc6a into main May 24, 2024
6 checks passed
@flo-dup flo-dup deleted the factorize_tapchangeradders branch May 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants