Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name unicity constraint on temporary limits #3043

Merged
merged 3 commits into from
May 31, 2024

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented May 30, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

When creating/importing a new temporary limit, its name should be unique in the LoadingLimits. If it is not the case, an exception is thrown.

What is the new behavior (if this is a feature change)?
This name unicity constraint is removed. When importing a new temporary limit, no check is performed on its name.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

No documentation change: the removed check was not described in it.

@annetill annetill requested a review from flo-dup May 31, 2024 07:51
Copy link

@flo-dup flo-dup merged commit dc0fb37 into main May 31, 2024
7 checks passed
@flo-dup flo-dup deleted the remove_temp_limits_name_unicity_check branch May 31, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants