Consider sides when applying limitReductions with IdentifiableCriterion #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
flo-dup
requested changes
Jun 10, 2024
Comment on lines
20
to
22
| * <p>Criterion checking that one of side of the network element belongs to a country defined in a list.</p> | ||
| * <p>When <code>filter</code> is called with a non-null <code>side</code>, only the country on this particular side | ||
| * is checked. Else, the validation is performed on whichever side.</p> |
There was a problem hiding this comment.
"on whichever side" does not reflect what's written in the code.
Suggested change
| * <p>Criterion checking that one of side of the network element belongs to a country defined in a list.</p> | |
| * <p>When <code>filter</code> is called with a non-null <code>side</code>, only the country on this particular side | |
| * is checked. Else, the validation is performed on whichever side.</p> | |
| * <p>Criterion checking that one of the sides of the network element belongs to a country defined in a list.</p> | |
| * <p>When {@link #filter(NetworkElement, ThreeSides)}} is called with a non-null <code>side</code>, only the country on this particular side | |
| * is checked.</p> |
iidm/iidm-criteria/src/main/java/com/powsybl/iidm/criteria/AtLeastOneCountryCriterion.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The AtLeast name is a bit unexpected now that there is this sides consideration.
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
flo-dup
approved these changes
Jun 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When a
LimitReductionis defined using anIdentifiableCriterion(to define a reduction on a voltage level for instance), the reduction is applied on each side of the network element if one of its sides verify the criterion.What is the new behavior (if this is a feature change)?
For
IdentifiableCriterion, the reduction is applied only on the side(s) verifying the criterion.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: