Add the ability to override minP and maxP to reflect generator temporary limits #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary limits Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
vidaldid-rte
requested review from
geofjamg,
jeandemanged,
rosiereflo,
annetill and
flo-dup
Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
vidaldid-rte
changed the title
annetill
reviewed
Jun 4, 2024
iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/ActivePowerControl.java
Outdated
Show resolved
Hide resolved
5 tasks
Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
annetill
reviewed
Jun 7, 2024
annetill
reviewed
Jun 7, 2024
iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/ActivePowerControl.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jun 7, 2024
...iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/ActivePowerControlImpl.java
Show resolved
Hide resolved
annetill
reviewed
Jun 7, 2024
| .build(), | ||
| new ImmutableMap.Builder<String, String>() | ||
| .put("1.0", "http://www.itesla_project.eu/schema/iidm/ext/active_power_control/1_0") | ||
| .put("1.1", "http://www.powsybl.org/schema/iidm/ext/active_power_control/1_1") | ||
| .put("1.2", "http://www.powsybl.org/schema/iidm/ext/active_power_control/1_2") |
There was a problem hiding this comment.
@flo-dup can you check serialization for me please?
Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
vidaldid-rte
force-pushed
the
override_pmin_pmax
branch
from
be145ba to
83ba2df
Compare
Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
flo-dup
reviewed
Jun 10, 2024
...iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/ActivePowerControlImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-serde/src/main/java/com/powsybl/iidm/serde/extensions/ActivePowerControlSerDe.java
Outdated
Show resolved
Hide resolved
iidm/iidm-serde/src/test/java/com/powsybl/iidm/serde/extensions/ActivePowerControlXmlTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
flo-dup
approved these changes
Jun 11, 2024
|
7 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Some generators have limit stricter than pMin and pMax for compensation operations or other short term active power control operations.
In order to capture these limites, the ActivePowerControl extension can store optional values for minPOverride and maxPOverride.
What kind of change does this PR introduce?
New optional fields in the ActivePowerControl extension
Does this PR introduce a breaking change or deprecate an API?
What changes might users need to make in their application due to this PR? (migration steps)
In order to take into account the overriden pMin and pMax, applications should check the value of the extension.
If the overridden limits are provided they should be used (instead of minP or maxP) for short term active power control operations.
Other information: