Allow zero value for limits in loading limits #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
annetill
reviewed
Jun 11, 2024
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ValidationUtil.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jun 11, 2024
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimitsAdder.java
Show resolved
Hide resolved
added 2 commits
June 12, 2024 14:21
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
olperr1
requested changes
Jun 14, 2024
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ValidationUtil.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimitsAdder.java
Outdated
Show resolved
Hide resolved
iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractCurrentLimitsTest.java
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimitsAdder.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ValidationUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
flo-dup
reviewed
Jun 26, 2024
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimitsAdder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
olperr1
approved these changes
Jun 27, 2024
|
olperr1
added
Breaking Change
olperr1
changed the title
olperr1
pushed a commit
that referenced
this pull request
Jul 1, 2024
* allow zero value in loading limit Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com> (cherry picked from commit 6582805)
geofjamg
pushed a commit
that referenced
this pull request
Sep 18, 2024
* allow zero value in loading limit Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
You could not add permanent or temporary limits to 0 (for
LoadingLimits).What is the new behavior (if this is a feature change)?
It is now allowed to set a value equal to zero in a
LoadingLimits(for permanent and temporary limits).Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
This is not really a breaking change, but you should be aware that
LoadingLimitscan now be imported/created with a zero value for permanent or temporary limits.As a consequence, you can now have a
Double.NaNif you divide something by one of these limits.For custom IIDM implementation maintainers:
You should now allow 0 as a value for permanent and temporary limits.