Fix ReferenceTerminals and SlackTerminal iIDM extension with merged networks and subnetworks #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandemanged
commented
Jun 20, 2024
iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/ReferenceTerminals.java
Show resolved
Hide resolved
jeandemanged
commented
Jun 20, 2024
iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/ReferenceTerminals.java
Show resolved
Hide resolved
jeandemanged
commented
Jun 20, 2024
iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/ReferenceTerminals.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
jeandemanged
changed the title
olperr1
requested changes
Jun 20, 2024
iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/ReferenceTerminals.java
Outdated
Show resolved
Hide resolved
...iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/ReferenceTerminalsImpl.java
Outdated
Show resolved
Hide resolved
olperr1
requested changes
Jun 20, 2024
...ck/src/test/java/com/powsybl/iidm/network/tck/extensions/AbstractReferenceTerminalsTest.java
Show resolved
Hide resolved
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
flo-dup
approved these changes
Jun 21, 2024
olperr1
approved these changes
Jun 21, 2024
|
4 tasks
geofjamg
pushed a commit
that referenced
this pull request
Sep 18, 2024
…etworks and subnetworks (#3076) * Fix ReferenceTerminals and SlackTerminal iIDM extension with merged networks and subnetworks Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
ReferenceTerminals and SlackTerminal iIDM extensions were never revisited to work properly with subnetworks.
In particular:
ReferenceTerminals.resetandSlackTerminal.resetdo not reset the subnetworksWhat is the new behavior (if this is a feature change)?
ReferenceTerminals fixed to properly check the network owning the terminal.
resetmethods will also reset the subnetworks.Does this PR introduce a breaking change or deprecate an API?