Fix regression on assert command for tool tests #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
olperr1
approved these changes
Jun 28, 2024
|
olperr1
pushed a commit
that referenced
this pull request
Jul 1, 2024
* revert deletion of assertCommand method to avoid regression * deprecate method Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com> (cherry picked from commit 90e4c30)
7 tasks
geofjamg
pushed a commit
that referenced
this pull request
Sep 18, 2024
* revert deletion of assertCommand method to avoid regression * deprecate method Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Due to #2777, a regression appeared: it was not anymore possible to use an
assertCommandwith an output and/or error message containing a regex since only strict string comparison were now availableWhat is the new behavior (if this is a feature change)?
assertCommandis back (but deprecated), adapted to the modifications from Refactor assert command #2777;assertCommandMatchTextOrRegexmethod was introduced, doing the same thing but with a clearer name.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: