Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network modification] Modify log when no extension is created. #3100

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

colinepiloquet
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) -> docs to do

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Log update

What is the current behavior?

The log message is pretty unclear without context, especially in the reporter:
"No extensions found on voltageLevel voltageLevel. The extension on the connectable is not created."

What is the new behavior (if this is a feature change)?
I tried to make the log a bit clearer by specifying the extension name: ConnectablePosition and the name of the feeder.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

…with its bay.

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Copy link

@olperr1 olperr1 merged commit 49bcb76 into main Jul 22, 2024
7 checks passed
@olperr1 olperr1 deleted the create_feeder_bay_fix_no_extension_log branch July 22, 2024 15:05
geofjamg pushed a commit that referenced this pull request Sep 18, 2024
* Modify the log when no extension is created when a feeder is created with its bay.
* Use already defined constant.

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants