Datasources - part 3: TarArchiveDataSource #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonenst
reviewed
Jul 18, 2024
| baseName, null, null, null); | ||
| } | ||
|
|
||
| public TarArchiveDataSource(Path tarFile) { |
There was a problem hiding this comment.
use private constructor with a FileInformation argument to avoid calling 3 times ?
jonenst
reviewed
Jul 18, 2024
| TarArchiveInputStream tar = new TarArchiveInputStream(cis)) { | ||
| ArchiveEntry entry; | ||
| while ((entry = tar.getNextEntry()) != null) { | ||
| // Consider only files located at the root of the archive |
There was a problem hiding this comment.
Maybe as a first version do the same as zip ? only filter on the matcher. (in the zip code the comment is wrong). Then in a separate PR we can decide if we implement this behavior for both ?
There was a problem hiding this comment.
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
flo-dup
force-pushed
the
nro/datasources_3_new_features
branch
from
47bf1a7 to
2a4ba27
Compare
flo-dup
requested changes
Aug 1, 2024
commons/src/main/java/com/powsybl/commons/datasource/FileInformation.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/com/powsybl/commons/datasource/TarArchiveDataSource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
flo-dup
reviewed
Aug 2, 2024
commons/src/main/java/com/powsybl/commons/datasource/TarArchiveDataSource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
|
flo-dup
approved these changes
Aug 2, 2024
jonenst
approved these changes
Aug 2, 2024
geofjamg
pushed a commit
that referenced
this pull request
Sep 18, 2024
* add TarArchiveDataSource * add unit test * make tar work like zip in listFiles * change test to show that files in every subfolder is reached Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Tar files cannot be used
What is the new behavior (if this is a feature change)?
Tar files can now be used as datasource
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: