Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special SVGs for dark mode #3104

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add special SVGs for dark mode #3104

merged 2 commits into from
Jul 18, 2024

Conversation

colinepiloquet
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Docs update

What is the current behavior?

In dark mode, the .svg files are not very visible as they have no background.

What is the new behavior (if this is a feature change)?
A new set of .svg files is added for dark mode. Each image is two files: one for light mode and one for dark mode.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet colinepiloquet requested a review from So-Fras July 17, 2024 15:12
Copy link

Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

@annetill annetill merged commit 958b11c into main Jul 18, 2024
7 checks passed
@annetill annetill deleted the dark_mode_svg branch July 18, 2024 11:11
geofjamg pushed a commit that referenced this pull request Sep 18, 2024
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants