Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create setters for temporary limits #3113

Merged
merged 17 commits into from
Aug 28, 2024
Merged

Create setters for temporary limits #3113

merged 17 commits into from
Aug 28, 2024

Conversation

nao1345678
Copy link
Contributor

@nao1345678 nao1345678 commented Aug 1, 2024 •
edited by olperr1
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #3060

What kind of change does this PR introduce?

With this change, we can now change the value of a temporary limit without having to recreate the whole limit.

What is the current behavior?

Temporary limits are immutable, which isn't practical if we only need to modify the limit's value.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Custom IIDM implementation maintainers should implement:
LoadingLimits.setTemporaryLimitValue(int acceptableDuration, double temporaryLimitValue)

Naledi EL CHEIKH added 9 commits June 7, 2024 14:10
allow zero value in loading limit
8de2e17 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
add a log if value is set to 0
fbc6c9d 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
add a log if value is set to 0
bd19fef 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
update : allow zero value on limits
8ff006d 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
added setter for temporary limit without order check
0ed6fa6 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
added a check if the limit isn't the lowest or the highest
409426e 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
update : all checks are done
dd3d33c 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
update on style corrections
744ee39 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
override impl optimized and added logs for errors
192d168 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
@nao1345678 nao1345678 marked this pull request as ready for review August 1, 2024 12:45
add : test with invalid value, delete validable, warn messages on logger
eeb3d77 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
Naledi EL CHEIKH added 3 commits August 5, 2024 16:37
Merge branch 'main' into create-setters-for-temporary-limits
ec4552b 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
add : class import
afaff72 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
deleted useless methods
ba9e6ce 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
olperr1
olperr1 requested changes Aug 6, 2024
View reviewed changes
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/OperationalLimitsGroupImpl.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/LoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/LoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimits.java Outdated Show resolved Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractLoadingLimits.java Show resolved Hide resolved
updated requested changes, added error handling
f6e73f8 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
@nao1345678 nao1345678 requested a review from olperr1 August 8, 2024 11:33
updated messages headers
5bcac3e 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
deleted setter for value in loading limits
5484772 
Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
colinepiloquet
colinepiloquet approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@colinepiloquet colinepiloquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@olperr1 olperr1 merged commit 3e22e4f into main Aug 28, 2024
7 checks passed
@olperr1 olperr1 deleted the create-setters-for-temporary-limits branch August 28, 2024 14:13
@olperr1 olperr1 added the Breaking Change API is broken label Aug 28, 2024
geofjamg pushed a commit that referenced this pull request Sep 18, 2024
@nao1345678 @geofjamg
Create setters for temporary limits (#3113)
73baf58 
Create setters for temporary limits (#3113)

Signed-off-by: Naledi EL CHEIKH <naledi.elcheikh@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinepiloquet colinepiloquet colinepiloquet approved these changes

@olperr1 olperr1 olperr1 approved these changes

@HugoKulesza HugoKulesza Awaiting requested review from HugoKulesza

Assignees
No one assigned
Labels
Breaking Change API is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operational limit setters
3 participants
@nao1345678 @olperr1 @colinepiloquet