Datasources - part 5: fixes #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jonenst
approved these changes
Aug 2, 2024
flo-dup
reviewed
Aug 2, 2024
cgmes/cgmes-model/src/main/java/com/powsybl/cgmes/model/CgmesOnDataSource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
flo-dup
force-pushed
the
nro/datasources_5_fixes
branch
from
71996d7 to
00bc3c2
Compare
This reverts commit 00bc3c2. Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
|
olperr1
approved these changes
Aug 8, 2024
flo-dup
approved these changes
Aug 9, 2024
geofjamg
pushed a commit
that referenced
this pull request
Sep 18, 2024
* check if file exist before opening stream in CgmesOnDataSource * EXTENSIONS to EXTENSION * Move the IOException catch to CgmesImport::exists(ReadOnlyDataSource) * Use parameterized unit tests on changed file CgmesOnDataSourceTest * Add IOException unit test Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com> Co-authored-by: Florian Dupuy <florian.dupuy@rte-france.com> Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
CgmesOnDataSource.checkIfMainFileNotWithCgmesData(), a stream was open without first checking if the file existed, which could result in an unexpected exception.What is the new behavior (if this is a feature change)?
CgmesOnDataSource.checkIfMainFileNotWithCgmesData(), we first check if the file exists before trying to open a stream on it.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
The following methods of
CgmesOnDataSourcenow throw anIOException:public boolean exists()public boolean existsCim14()If you call them, you should catch or propagate this exception. To keep the same behavior as before, you can catch this exception and propagate it in a new
UncheckedIOException.Other information: