Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation corrections #3124

Merged
merged 7 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
These are the documentation sources for PowSybl core features.
These are the documentation sources for PowSyBl core features.

Please keep them up to date with your developments.
They are published on powsybl.readthedocs.io/ and pull requests are built and previewed automatically.
Expand Down Expand Up @@ -27,8 +27,8 @@ sphinx-build -a . ../build-docs
Then open `build-docs/index.html` in your browser.

If you want to add links to another documentation, add the corresponding repository to the `conf.py` file.
In order to automatically get the version specified in the `pom.xml`, please use the same naming as the version: if you define the
Groovy version with `<groovy.version>`, then use `groovy` as key. The specified URL should start with `https://` and end with `latest/` (the final `/` is mandatory).
To automatically get the version specified in the `pom.xml`, please use the same naming as the version: if you define the
Groovy version with `<groovy.version>`, then use `groovy` as a key. The specified URL should start with `https://` and end with `latest/` (the final `/` is mandatory).
For example, to add a link to the documentation of Sphinx, you need to add the following lines:
~~~python
# This parameter might already be present, just add the new value
Expand All @@ -38,7 +38,7 @@ intersphinx_mapping = {
~~~

Then in your documentation file, you can add links to PowSyBl-Core documentation. If you want to link to a whole page,
use one of the following example:
use one of the following examples:
~~~Markdown
- {doc}`sphinx:usage/extensions/intersphinx`
- {doc}`Intersphinx <sphinx:usage/extensions/intersphinx>`
Expand Down
6 changes: 3 additions & 3 deletions docs/data/timeseries.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ in the framework, depending on the need:
- [Irregular index](https://en.wikipedia.org/wiki/Unevenly_spaced_time_series): the time step size varies
- Infinite index: the time series contains only two points, one at instant 0 and another at instant `Long.MAX_VALUE`
- Metadata: a list of key/value string data
- Data chunks: an ordered list of data that will be associated to instants of the time index. The data chunks may be compressed or uncompressed.
- Data chunks: an ordered list of data that will be associated with instants of the time index. The data chunks may be compressed or uncompressed.

An uncompressed JSON data chunk looks like:
```json
Expand All @@ -24,7 +24,7 @@ An uncompressed JSON data chunk looks like:
An uncompressed data chunk is modeled with a double (or String) array and an offset.
It defines values associated to instants of the time index from `offset` to `offset + values.length`.

It is possible to compress the data chunks, using for example the [RLE](https://fr.wikipedia.org/wiki/Run-length_encoding).
It is possible to compress the data chunks, using, for example, the [RLE](https://fr.wikipedia.org/wiki/Run-length_encoding).
The JSON serialization of compressed data chunks looks like:
Output:
```json
Expand Down Expand Up @@ -114,7 +114,7 @@ Here is the list of supported vector operations:
In the Groovy DSL syntax, both `timeSeries['a']` and `ts['a']` are supported and are equivalent.

To compare a time index vector to a literal date, the `time('2018-01-01T00:00:01Z')` function is available. For instance, the
following code create a time series of 0 and 1 values:
following code creates a time series of 0 and 1 values:
```groovy
a = ts['dts'].time() < time('2018-01-01T00:00:01Z')
```
Expand Down
2 changes: 1 addition & 1 deletion docs/grid_exchange_formats/ampl/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ example.md

The [AMPL](https://ampl.com/) (**A** **M**athematical **P**rogramming **L**anguage) format is an algebraic modeling language to describe and solve high-complexity problems for large-scale mathematical computing (i.e. large-scale optimization and scheduling-type problems).

IIDM networks can be converted in flat text files easy to read in AMPL, each of which describing one type of the network equipments (batteries, generators, loads, branches, buses, etc.).
IIDM networks can be converted in flat text files easy to read in AMPL, each of which describing one type of the network equipment (batteries, generators, loads, branches, buses, etc.).
38 changes: 19 additions & 19 deletions docs/grid_exchange_formats/cgmes/export.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Export

There are two main use-cases supported:
* Export IGM (Individual Grid Model) instance files. There is a single network and a unique CGMES modelling authority.
* Export IGM (Individual Grid Model) instance files. There is a single network and a unique CGMES modeling authority.
* Export CGM (Common Grid Model) instance files. A network composed of multiple subnetworks, where each subnetwork is an IGM.

In both cases, the metadata model information in the exported files is built from metadata information read from the input files and stored in IIDM or received through parameters.
Expand All @@ -10,7 +10,7 @@ Information received through parameters takes precedence over information availa
For a quick CGM export, the user may rely on the parameter **iidm.export.cgmes.cgm_export** to write in a single export multiple updated SSH files (one for each IGM) and a single SV for the whole common grid model. Specifics about this option are explained in the section [below](#cgm-common-grid-model-quick-export).
If you need complete control over the exported files in a CGM scenario, you may prefer to iterate through the subnetworks and make multiple calls to the export function. This is described in detail in the section [below](#cgm-common-grid-model-manual-export).

Please note that when exporting equipment, PowSyBl always use the CGMES node/breaker level of detail, without considering the topology
Please note that when exporting equipment, PowSyBl always uses the CGMES node/breaker level of detail, without considering the topology
level of the PowSyBl network.

The user can specify the profiles to be exported using the parameter **iidm.export.cgmes.profiles**. The list of currently supported export instance files are: EQ, SSH, SV, TP.
Expand Down Expand Up @@ -47,7 +47,7 @@ The filenames of the exported instance files will follow the pattern:

The basename is determined from the parameters, or the basename of the export data source or the main network name.

As an example, you can export one of the test configurations that has been provided by ENTSO-E. It is available in the cgmes-conformity module of the powsybl-core repository. If you run the following code:
As an example, you can export one of the test configurations that have been provided by ENTSO-E. It is available in the cgmes-conformity module of the powsybl-core repository. If you run the following code:

```java
Network cgmNetwork = Network.read(CgmesConformity1Catalog.microGridBaseCaseAssembled().dataSource());
Expand Down Expand Up @@ -76,7 +76,7 @@ where the updated SSH files will supersede the original ones, and the SV will co

If you want to intervene in how the updated IGM SSH files or the CGM SV are exported, you can make multiple calls to the CGMES export function.

You can use following code for reference:
You can use the following code for reference:

```java
Network cgmNetwork = Network.read(CgmesConformity1Catalog.microGridBaseCaseAssembled().dataSource());
Expand Down Expand Up @@ -145,7 +145,7 @@ And the file `manualExampleBasename_SV.xml` will contain:
<md:Model.DependentOn rdf:resource="mySvDependency1"/>
<md:Model.DependentOn rdf:resource="mySvDependency2"/>
<md:Model.profile>http://entsoe.eu/CIM/StateVariables/4/1</md:Model.profile>
<md:Model.modelingAuthoritySet>myModellinAuthority</md:Model.modelingAuthoritySet>
<md:Model.modelingAuthoritySet>myModelingAuthority</md:Model.modelingAuthoritySet>
...
```

Expand Down Expand Up @@ -180,8 +180,8 @@ PowSyBl [`Generator`](../../grid_model/network_subnetwork.md#generator) is expor

#### Regulating control

If the network comes from a CIM-CGMES model and a generator has initially a `RegulatingControl`, it always has at export
too. Otherwise, a `RegulatingControl` is always exported for generators, except if it has no regulating capabilities because
If the network comes from a CIM-CGMES model and a generator initially has a `RegulatingControl`, it will still have one at export.
Otherwise, a `RegulatingControl` is always exported for generators, except if it has no regulating capabilities because
$minQ = maxQ$.

A `RegulatingControl` is exported with `RegulatingControl.mode` set to `RegulatingControlModeKind.reactivePower` when a
Expand Down Expand Up @@ -213,10 +213,10 @@ PowSyBl [`ShuntCompensator`](../../grid_model/network_subnetwork.md#shunt-compen

#### Regulating control

If the network comes from a CIM-CGMES model and a shunt compensator has initially a `RegulatingControl`, it always
has at export too.
If the network comes from a CIM-CGMES model and a shunt compensator initially has a `RegulatingControl`, it will still
have one at export.

A shunt compensator with local voltage control (i.e. the regulating terminal is the same of the terminal of connection)
A shunt compensator with local voltage control (i.e., the regulating terminal is the same of the terminal of connection)
and no valid voltage target will not have any exported regulating control. In all other cases, a `RegulatingControl`
is exported with `RegulatingControl.mode` set to `RegulatingControlModeKind.voltage`.

Expand All @@ -226,10 +226,10 @@ PowSyBl [`StaticVarCompensator`](../../grid_model/network_subnetwork.md#static-v

#### Regulating control

If the network comes from a CIM-CGMES model and a static VAR compensator has initially a `RegulatingControl`, it always
has at export too.
If the network comes from a CIM-CGMES model and a static VAR compensator initially has a `RegulatingControl`, it will still
have one at export.

A static VAR compensator which voltage control is local (i.e. the regulating terminal is the same of the terminal of
A static VAR compensator which voltage control is local (i.e., the regulating terminal is the same of the terminal of
connection) and no valid voltage or reactive power target will not have any exported regulating control.

A `RegulatingControl` is exported with `RegulatingControl.mode` set to `RegulatingControlModeKind.reactivePower` when
Expand All @@ -252,7 +252,7 @@ PowSyBl [`Switch`](../../grid_model/network_subnetwork.md#breakerswitch) is expo

### ThreeWindingsTransformer

PowSyBl [`ThreeWindingsTransformer`](../../grid_model/network_subnetwork.md#three-windings-transformer) is exported as `PowerTransformer` with three `PowerTransformerEnds`.
PowSyBl [`ThreeWindingsTransformer`](../../grid_model/network_subnetwork.md#three-winding-transformer) is exported as `PowerTransformer` with three `PowerTransformerEnds`.

#### Tap changer control

Expand All @@ -272,13 +272,13 @@ when `PhaseTapChanger` `regulationMode` is set to `CURRENT_LIMITER`.

### TwoWindingsTransformer

PowSyBl [`TwoWindingsTransformer`](../../grid_model/network_subnetwork.md#two-windings-transformer) is exported as `PowerTransformer` with two `PowerTransformerEnds`.
PowSyBl [`TwoWindingsTransformer`](../../grid_model/network_subnetwork.md#two-winding-transformer) is exported as `PowerTransformer` with two `PowerTransformerEnds`.

Tap changer controls for two windings transformers are exported following the same rules explained in the previous section about three windings transformers. See [tap changer control](#tap-changer-control).
Tap changer controls for two-winding transformers are exported following the same rules explained in the previous section about three-winding transformers. See [tap changer control](#tap-changer-control).

### Voltage level

PowSybl [`VoltatgeLevel`](../../grid_model/network_subnetwork.md#voltage-level) is exported as `VoltageLevel`.
PowSyBl [`VoltageLevel`](../../grid_model/network_subnetwork.md#voltage-level) is exported as `VoltageLevel`.

<span style="color: red">TODO details</span>

Expand Down Expand Up @@ -362,7 +362,7 @@ Optional property defining whether the transformers should be exported with the
This property is set to `false` by default.

**iidm.export.cgmes.export-load-flow-status**
Optional property that indicates whether the loadflow status (`converged` or `diverged`) should be
Optional property that indicates whether the load flow status (`converged` or `diverged`) should be
written for the `TopologicalIslands` in the SV file. If `true`, the status will be computed by checking, for every bus,
if the voltage and angle are valid, and if the bus is respecting Kirchhoff's first law. For the latter, we check that
the sums of active power and reactive power at the bus are higher than a threshold defined by the properties
Expand All @@ -380,7 +380,7 @@ Optional property to specify if the total mismatch left after power flow calcula
This property is set to `true` by default.

**iidm.export.cgmes.sourcing-actor**
Optional property allowing to specify a custom sourcing actor. If a Boundary set with reference data is provided for the export through the parameter `iidm.import.cgmes.boundary-location`, the value of this property will be used to look for the modelling authority set and the geographical region to be used in the export.
Optional property allowing to specify a custom sourcing actor. If a Boundary set with reference data is provided for the export through the parameter `iidm.import.cgmes.boundary-location`, the value of this property will be used to look for the modeling authority set and the geographical region to be used in the export.
No default value is given.
If this property is not given, the export process will still try to determine the sourcing actor from the IIDM network if it only contains one country.

Expand Down
Loading