-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CGMES import and export of OperationalLimits #3139
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f2c2560
Create an OperationalLimitsGroup for each combination of OperationalL…
rcourtier 2e7671f
Create a common OperationalLimitsGroup for OperationalLimitSet having…
rcourtier 70f6a11
Fix CGMES export to avoid duplicate OperationalLimitType and map 1 CG…
rcourtier fac231f
Reworked setting of selected group to avoid changing IIDM API
rcourtier 6c1779c
Add a parameter to export all OperationalLimitsGroup or only the sele…
rcourtier 3045afa
Reworked to comply with quality gate
rcourtier 9916f5e
Add documentation (CGMES import and export and IIDM modeling)
rcourtier faf6b05
Merge branch 'main' into cgmes_import_handle_multiple_limitsgroups
zamarrenolm 20a4dfa
Map the CGMES OperationalLimitSet.rdfid to the IIDM OperationalLimits…
rcourtier 1be3e9e
Support CGMES import and export of OperationalLimitSet.rdfid and name…
rcourtier 1d1b34d
Merge branch 'main' into cgmes_import_handle_multiple_limitsgroups
zamarrenolm 041d5fe
Review the LoadingLimitsMapping class: map the LoadingLimitsAdders wi…
rcourtier 7046313
Using OperationalLimitSet mRID instead of rdf:ID.
rcourtier 790824f
Merge branch 'main' into cgmes_import_handle_multiple_limitsgroups
olperr1 c141a48
Simplify the addAll method in LoadingLimitsMapping
rcourtier 6684c68
Integrate the limits validity check in a filter of the stream
rcourtier 2adbd5d
Merge branch 'main' into cgmes_import_handle_multiple_limitsgroups
zamarrenolm 6b6a125
Keep the 3w-transformer stream instead of casting it to a set
rcourtier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that to avoid all these loops we could do the selection in
LoadingLimitsMapping::addAll
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difficulty is that we should loop over all FlowsLimitsHolder to set the selected set, but there is no easy link to go from OperationalLimitsGroup which we have in LoadingLimitsMapping to FlowsLimitsHolder.