[CGMES GL] Add SubstationPosition extension when location on voltage levels #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
olperr1
reviewed
Sep 26, 2024
olperr1
approved these changes
Sep 26, 2024
So-Fras
requested changes
Sep 26, 2024
| public PropertyBags getSubstationsPosition() { | ||
| LOG.info("Querying triple store for substations positions"); | ||
| return queryTripleStore(SUBSTASTION_POSITION_QUERY_KEY); | ||
| public PropertyBags getSubstationsVoltageLevelsPosition() { |
There was a problem hiding this comment.
Suggested change
| public PropertyBags getSubstationsVoltageLevelsPosition() { | |
| public PropertyBags getSubstationVoltageLevelPosition() { |
There was a problem hiding this comment.
getSubstationVoltageLevelPositions() (one query for all positions)
cgmes/cgmes-gl/src/main/java/com/powsybl/cgmes/gl/CgmesGLModel.java
Outdated
Show resolved
Hide resolved
cgmes/cgmes-gl/src/main/java/com/powsybl/cgmes/gl/CgmesGLModel.java
Outdated
Show resolved
Hide resolved
cgmes/cgmes-gl/src/main/java/com/powsybl/cgmes/gl/CgmesGLModel.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com> Signed-off-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
So-Fras
approved these changes
Sep 27, 2024
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
feature
What is the current behavior?
In CGMES GL import, only locations on substations PowerSystemResource are supported
What is the new behavior (if this is a feature change)?
In CGMES GL import, locations on substations and voltage levels PowerSystemResource are supported
Does this PR introduce a breaking change or deprecate an API?
Other information: