-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getI() method to DanglingLine's boundary #3168
Conversation
Signed-off-by: Caio Luke <caioluke97@gmail.com>
getI()
method to DanglingLine's boundary
getI()
method to DanglingLine's boundarySigned-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Caio Luke <caioluke97@gmail.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Hi @olperr1 , |
Hi @jeandemanged, |
Quality Gate passedIssues Measures |
I double-checked the |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Boundary nodes do not have a
getI()
method, whereas terminals do. Therefore, for paired dangling lines, we can not get the current from both sides of the half line easily.What is the new behavior (if this is a feature change)?
Add the
getI()
method for boundary nodes.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Custom IIDM implementations that are implementing the
Boundary
interface (which is not necessarily the case) should add the following method to their implementation:double getI();