Rework missing voltage level test (remove conformity modified file) #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a modified conformity one Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
rcourtier
force-pushed
the
missing_voltagelevel_preprocessor_test
branch
from
5e5d68a to
0e5c704
Compare
zamarrenolm
approved these changes
Nov 4, 2024
|
olperr1
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Rework an existing test
What is the current behavior?
CGMES completion test is using a modified conformity network
What is the new behavior (if this is a feature change)?
CGMES completion test is using a simple network
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
The following method of
CgmesConformity1ModifiedCatalog, was removed:miniGridNodeBreakerMissingVoltageLevel()It was used for unit testing, but it relied on big CGMES files ; this slowed the tests execution. If you still need to use it, you can retrieve the method at this URL and the corresponding CGMES files in this directory.