Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add percent change load action #3189

Merged
merged 30 commits into from
Nov 21, 2024
Merged

Add percent change load action #3189

merged 30 commits into from
Nov 21, 2024

Conversation

bc-rte
Copy link
Contributor

@bc-rte bc-rte commented Oct 23, 2024 •
edited by olperr1
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

#3078

What kind of change does this PR introduce?

This PR adds a new action, and the corresponding network modification, that allows users to change a load without knowing existing values, by specifying a percent P0 change and its impact on Q0.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@bc-rte bc-rte requested a review from alicecaron October 23, 2024 13:48
@alicecaron alicecaron linked an issue Oct 24, 2024 that may be closed by this pull request
Actions API : LoadAction with % value #3078
Closed
@bc-rte bc-rte force-pushed the add_pct_load_shedding_action branch 2 times, most recently from 3a96a6d to b0d19fd Compare October 28, 2024 09:03
olperr1
olperr1 requested changes Oct 30, 2024
View reviewed changes
@bc-rte bc-rte force-pushed the add_pct_load_shedding_action branch 3 times, most recently from 7139bdd to 287f78f Compare October 30, 2024 19:18
@olperr1
Copy link
Member

olperr1 commented Oct 31, 2024

For the documentation, I suggest the following change in docs/simulation/security/index.md:

- - Change the active and/or reactive power of a load
+ - Change the active and/or reactive power of a load (by setting the values, or defining changes in value or percentage)

bc-rte and others added 18 commits November 4, 2024 09:40
@bc-rte
create pct load modification
8bf2525 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
add pctLoadAction
9ce130f 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte @olperr1
Update action-api/src/main/java/com/powsybl/action/PctLoadAction.java
816efa1 
Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: bc-rte <142609826+bc-rte@users.noreply.github.com>
@bc-rte @olperr1
Update action-api/src/main/java/com/powsybl/action/PctLoadAction.java
4eb0a79 
Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: bc-rte <142609826+bc-rte@users.noreply.github.com>
@bc-rte @olperr1
Update action-api/src/main/java/com/powsybl/action/PctLoadAction.java
66eca06 
Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: bc-rte <142609826+bc-rte@users.noreply.github.com>
@bc-rte
refactor: rename
9aefe69 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: rename
85d1edc 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: rename
791a0dc 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: rename
6a21aca 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: test double impl
7960515 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: rename
1daebf3 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: rename
3af823f 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: use builder instead
0a43a74 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: change assertion library
bd4fc4f 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: more precise error message
a58a13f 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
fix: remove unneeded interface
fdc7f87 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
fix: typo
555fe98 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: remove intermediary
0ad9302 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
bc-rte added 6 commits November 4, 2024 09:40
@bc-rte
refactor: add test
64da5b3 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: change doc
b6995ca 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
fix: tests
5cf88ae 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
fix: only throw when needed
b22763a 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
add documentation
759e4a9 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
refactor: change namess, add delta precision to test
35b9004 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte bc-rte force-pushed the add_pct_load_shedding_action branch from bba921d to 35b9004 Compare November 4, 2024 08:40
@bc-rte @olperr1
Update action-api/src/main/java/com/powsybl/action/PercentChangeLoadA…
d53013d 
…ctionBuilder.java

Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: bc-rte <142609826+bc-rte@users.noreply.github.com>
bc-rte and others added 4 commits November 20, 2024 16:38
@bc-rte @alicecaron
Update action-api/src/main/java/com/powsybl/action/json/PercentChange…
0100612 
…LoadActionBuilderDeserializer.java

Co-authored-by: alicecaron <alicecaron94@gmail.com>
Signed-off-by: bc-rte <142609826+bc-rte@users.noreply.github.com>
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
fix: change action name string
4ed11bf 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
add assertion on error message
cedac23 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte
add test just below the %change threshold
ab79f54 
Signed-off-by: CHIQUET Benoit <benoit.chiquet@rte-france.com>
@bc-rte bc-rte force-pushed the add_pct_load_shedding_action branch from 3315671 to ab79f54 Compare November 20, 2024 15:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@olperr1 olperr1 changed the title Add pct load shedding action Add percent change load action Nov 21, 2024
@olperr1 olperr1 merged commit b381318 into main Nov 21, 2024
7 checks passed
@olperr1 olperr1 deleted the add_pct_load_shedding_action branch November 21, 2024 08:23
@So-Fras So-Fras mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicecaron alicecaron alicecaron approved these changes

@olperr1 olperr1 olperr1 approved these changes

Assignees
No one assigned
Labels
December 2024 release
Projects
Release 12/2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actions API : LoadAction with % value
3 participants
@bc-rte @olperr1 @alicecaron