Fix load flow default parameters loading mechanism #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
olperr1
requested changes
Oct 29, 2024
loadflow/loadflow-api/src/main/java/com/powsybl/loadflow/LoadFlowParameters.java
Show resolved
Hide resolved
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>
|
olperr1
changed the title
olperr1
approved these changes
Oct 30, 2024
olperr1
pushed a commit
that referenced
this pull request
Oct 30, 2024
* refactor load flow parameters loading from config * remove duplicate config set * add test to check the correct modification order Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com> (cherry picked from commit 4b8599d)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug
What is the current behavior?
When loading loadflow parameters from a PlatformConfig, every field of the LoadFlowParameters is either set to the value written in the config or to its default value (if the configuration module
load-flow-default-parametersis used).It is a problem for the
LoadFlowDefaultParametersLoadermechanism (introduced by #3040) that is meant to change values before the PlatformConfig load.As a additional related problem, the old
noGeneratorReactiveLimitsparameter (now replaced byuseReactiveLimits) is ignored: its value is overwritten by the default value ofuseReactiveLimits.What is the new behavior (if this is a feature change)?
Now the loading only changes fields that are specified in the configuration file, and does not modify the absent ones.
The backward compatibility of the
noGeneratorReactiveLimitsparameter is also fixed.Does this PR introduce a breaking change or deprecate an API?