Refactor voltage level topology implementation #3196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Refactoring
What is the current behavior?
The 2 topology models bus/breaker and node/breaker are implemented by 2 inherited classes from AbstractVoltageLevel.
What is the new behavior (if this is a feature change)?
A new TopologyModel concept has been added so that we only have one voltage level implementation class delegating every specific code to a topology model to a dedicated class.
Main advantages:
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
Noticeable changes:
AbstractVoltageLevel
was replaced by non-abstract classVoltageLevelImpl
.BusBreakerVoltageLevel
andNodeBreakerVoltageLevel
were removed. Their topology management methods were respectively moved in new classesBusBreakerTopologyModel
andNodeBreakerTopologyModel
, implementing a newModelTopology
interface.BusBreakerVoltageLevel.class
orNodeBreakerVoltageLevel.class
. They are now all mapped toVoltageLevelImpl.class
.VoltageLevelExt
were removed. These operations can be performed on theTopologyModel
, accessible viavoltageLevel.getTopologyModel()
:attach(TerminalExt, boolean)
detach(TerminalExt)
connect(TerminalExt, Predicate<? super SwitchImpl>)
disconnect(TerminalExt, Predicate<? super SwitchImpl>)
invalidateCache()
invalidateCache(boolean)