Voltage level topology model conversion #3199

geofjamg · 2024-11-05T16:36:32Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the new behavior (if this is a feature change)?
We are able to change the topology kind of voltage level. For now we are only capable to convert a node/breaker voltage level topology to a bus/breaker one.

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

# Conflicts: # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/BusBreakerTopologyModel.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/VoltageLevelImpl.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

# Conflicts: # iidm/iidm-api/src/main/java/com/powsybl/iidm/network/NetworkEventRecorder.java # iidm/iidm-api/src/main/java/com/powsybl/iidm/network/events/ExtensionUpdateNetworkEvent.java # iidm/iidm-api/src/main/java/com/powsybl/iidm/network/events/NetworkEvent.java # math/src/main/java/com/powsybl/math/graph/UndirectedGraph.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

…onversion # Conflicts: # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractTerminal.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/TerminalExt.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

# Conflicts: # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractIidmExtension.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractTerminal.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AreaImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/DanglingLineBoundaryImplExt.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/DanglingLineImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/PhaseTapChangerImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/RatioTapChangerImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/Referrer.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/RegulatingPoint.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/ReferenceTerminalsImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/RemoteReactivePowerControlImpl.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/SlackTerminalImpl.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractConnectable.java

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AreaBoundaryImpl.java

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/VoltageLevelImpl.java

flo-dup · 2024-12-03T16:43:47Z

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/VoltageLevelImpl.java

+
+                    // if there is no way to find a connectable bus, remove the connectable
+                    // an alternative would be to connect them all to a new trash configured bus
+                    if (connectableBus != null) {


Isn't there's always a non-null connectableBus? A connectable is tied to a node, and a CalculatedBus is always created for a non-empty set of nodes:

powsybl-core/iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java

Lines 491 to 496 in 218eb50

private static final class CalculatedBusBreakerChecker implements BusChecker {

@Override

public boolean isValid(UndirectedGraph<? extends TerminalExt, SwitchImpl> graph, TIntArrayList nodes, List<NodeTerminal> terminals) {

return !nodes.isEmpty();

}

}

I'm almost sure I already seen null connectable bus ID in the bus/breaker view of a node/breaker topology when all switches are open.

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractConnectable.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

sonarqubecloud · 2024-12-04T12:20:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

geofjamg added 5 commits November 5, 2024 11:05

Refactor voltage level topology implementation

65d8a01

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Wip

5272a31

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Voltage level topology model conversion

0cdc075

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix

706c9eb

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Wip

8684af9

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Base automatically changed from topology_model to main November 7, 2024 09:17

geofjamg added 16 commits November 7, 2024 10:44

Clean

6275991

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Add network events to IIDM API

fde8da4

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Add unit tests

c380bfa

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean

3dd4c87

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Wip

bd56b88

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean all deprecated methods and remame element to property

4d5ff02

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean

1f8f266

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean

43defb6

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge branch 'main' into network_events

7ae843d

Rename attribute to key and Property to Properties

9ac7c91

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean

e9c698a

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge

65b8f55

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean

cbd28a4

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge branch 'network_events' into topology_model_conversion

96ffd8a

geofjamg changed the base branch from main to network_events November 12, 2024 10:22

Base automatically changed from network_events to main November 12, 2024 10:37

Merge branch 'main' into topology_model_conversion

32f6b9e

geofjamg requested a review from flo-dup November 12, 2024 12:20

geofjamg changed the title ~~[WIP] Voltage level topology model conversion~~ Voltage level topology model conversion Nov 12, 2024

geofjamg added 3 commits November 12, 2024 17:28

Fix regulating terminals

3646956

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix busbar section

f6ed9a3

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix

21ff2ed

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg added 4 commits November 27, 2024 10:10

Rename dependant to referrer

1208d0e

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge branch 'main' into fix_dangling_terminal_references

929c7ea

Merge branch 'fix_dangling_terminal_references' into topology_model_c…

01c2aff

…onversion # Conflicts: # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractTerminal.java # iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/TerminalExt.java

Merge

7d67cc5

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg changed the base branch from main to fix_dangling_terminal_references November 27, 2024 11:29

geofjamg added the December 2024 release label Nov 27, 2024

Base automatically changed from fix_dangling_terminal_references to main November 28, 2024 09:44

geofjamg added 4 commits November 28, 2024 11:11

Fix merge

c2af5cf

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix

a797b15

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge branch 'main' into topology_model_conversion

0241fe5

flo-dup requested changes Dec 3, 2024

View reviewed changes

geofjamg added 5 commits December 4, 2024 08:41

Review fixes

44af0c6

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Simplify

39a6a9c

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Simplify

44d8e42

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Refactoring

11b9ea1

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge branch 'main' into topology_model_conversion

11a93f0

geofjamg requested a review from flo-dup December 4, 2024 08:45

geofjamg added 2 commits December 4, 2024 10:19

Add unit test

f28112a

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Add unit test

bd6e5eb

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

flo-dup reviewed Dec 4, 2024

View reviewed changes

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractConnectable.java Outdated Show resolved Hide resolved

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractConnectable.java Outdated Show resolved Hide resolved

geofjamg added 4 commits December 4, 2024 11:24

Clean

a9e6430

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean

9f486bd

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Add unit test

6ea6dfc

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Add unit test

1571d78

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg requested a review from flo-dup December 4, 2024 12:30

flo-dup approved these changes Dec 4, 2024

View reviewed changes

flo-dup merged commit d66b8cc into main Dec 4, 2024
8 checks passed

flo-dup deleted the topology_model_conversion branch December 4, 2024 12:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Voltage level topology model conversion #3199

Voltage level topology model conversion #3199

geofjamg commented Nov 5, 2024 •

edited

Loading

flo-dup Dec 3, 2024

geofjamg Dec 4, 2024

sonarqubecloud bot commented Dec 4, 2024

	private static final class CalculatedBusBreakerChecker implements BusChecker {
	@Override
	public boolean isValid(UndirectedGraph<? extends TerminalExt, SwitchImpl> graph, TIntArrayList nodes, List<NodeTerminal> terminals) {
	return !nodes.isEmpty();
	}
	}

Voltage level topology model conversion #3199

Voltage level topology model conversion #3199

Conversation

geofjamg commented Nov 5, 2024 • edited Loading

flo-dup Dec 3, 2024

Choose a reason for hiding this comment

geofjamg Dec 4, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 4, 2024

Quality Gate passed

geofjamg commented Nov 5, 2024 •

edited

Loading