Add area interchange target update action #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-guibert FYI |
jeandemanged
requested changes
Nov 14, 2024
olperr1
requested changes
Nov 14, 2024
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetUpdateAction.java
Outdated
Show resolved
Hide resolved
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetUpdateAction.java
Outdated
Show resolved
Hide resolved
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetUpdateActionBuilder.java
Outdated
Show resolved
Hide resolved
|
Shouldn't the corresponding |
jeandemanged
requested changes
Nov 14, 2024
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetUpdateActionBuilder.java
Outdated
Show resolved
Hide resolved
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetUpdateAction.java
Outdated
Show resolved
Hide resolved
action-api/src/test/java/com/powsybl/action/json/JsonActionTest.java
Outdated
Show resolved
Hide resolved
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetUpdateAction.java
Outdated
Show resolved
Hide resolved
Yes it is coming ! |
jeandemanged
requested changes
Nov 14, 2024
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetUpdateAction.java
Outdated
Show resolved
Hide resolved
jeandemanged
requested changes
Nov 15, 2024
...odification/src/test/java/com/powsybl/iidm/modification/AreaInterchangeModificationTest.java
Outdated
Show resolved
Hide resolved
...odification/src/test/java/com/powsybl/iidm/modification/AreaInterchangeModificationTest.java
Outdated
Show resolved
Hide resolved
jeandemanged
requested changes
Nov 18, 2024
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
obrix
force-pushed
the
interchange_update_action
branch
from
fe72dd9 to
946208d
Compare
olperr1
requested changes
Nov 19, 2024
...ification/src/main/java/com/powsybl/iidm/modification/AreaInterchangeTargetModification.java
Outdated
Show resolved
Hide resolved
...odification/src/test/java/com/powsybl/iidm/modification/AreaInterchangeModificationTest.java
Show resolved
Hide resolved
...odification/src/test/java/com/powsybl/iidm/modification/AreaInterchangeModificationTest.java
Show resolved
Hide resolved
action-api/src/main/java/com/powsybl/action/AreaInterchangeTargetActionBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
olperr1
requested changes
Nov 20, 2024
...ification/src/main/java/com/powsybl/iidm/modification/AreaInterchangeTargetModification.java
Outdated
Show resolved
Hide resolved
olperr1
approved these changes
Nov 20, 2024
jeandemanged
approved these changes
Nov 20, 2024
olperr1
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Sorry, I missed another thing.
Can you add the action description in the list of the supported actions in the documentation?
(in this section)
olperr1
approved these changes
Nov 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#3157
What kind of change does this PR introduce?
Introduce an action for area interchange target update. To be used in combination with generator and load action in a security analysis to implement a full countertrading process that impact the area interchange targets.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: