Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switch contingency support #3229

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Fix switch contingency support #3229

merged 3 commits into from
Nov 28, 2024

Conversation

EtienneLt
Copy link
Contributor

@EtienneLt EtienneLt commented Nov 27, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Switch contingency type is not fully supported: no validation + no deserialization

What is the new behavior (if this is a feature change)?
Switch contingency type is supported at validation and deserialization.
+ add unit tests on other contingency types.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@EtienneLt EtienneLt self-assigned this Nov 27, 2024
@EtienneLt EtienneLt requested a review from olperr1 November 27, 2024 12:54
@olperr1 olperr1 requested a review from So-Fras November 27, 2024 15:35
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@olperr1 olperr1 force-pushed the fix-switch-contingency branch from 07274ef to 32e392d Compare November 27, 2024 15:44
@olperr1 olperr1 changed the title Fix switch contingency Fix switch contingency support Nov 27, 2024
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@olperr1 olperr1 merged commit 96c7f96 into main Nov 28, 2024
7 checks passed
@olperr1 olperr1 deleted the fix-switch-contingency branch November 28, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants