cim:Jumper support #3235
Merged
cim:Jumper support #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
rcourtier
requested changes
Dec 3, 2024
...s/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/JumperConversionTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+121
to
+122
| } else if (type.contains("jumper")) { | ||
| return SwitchKind.DISCONNECTOR; |
There was a problem hiding this comment.
The property bag has for "type" the whole value with the namespace (type -> http://iec.ch/TC57/2013/CIM-schema-cim16#Jumper), but getLocal removes the namespace prefix. In the end, the value we get is exactly the class name. So I guess we could test with "jumper".equals(type) instead.
However, I propose we do it in a separate PR. That way we can change it for all switch types.
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
rcourtier
requested changes
Dec 4, 2024
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
rcourtier
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No, but a slack user did request it
What kind of change does this PR introduce?
feature
What is the current behavior?
cim:Jumper are ignored at CGMES/cim import
What is the new behavior (if this is a feature change)?
cim:Jumper are imported as disconnectors
Does this PR introduce a breaking change or deprecate an API?