-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Extrapolation of getMinQ and getMaxQ for reactive capability curve #3250
Open
SylvestreSakti
wants to merge
8
commits into
main
Choose a base branch
from
reactive_capability_curve_extrapolation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apolation of reactive limit slope Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
…d maxQ when extrapolated Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/ReactiveCapabilityCurve.java
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveImpl.java
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveImpl.java
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/test/java/com/powsybl/iidm/network/impl/ReactiveCapabilityCurveImplTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
vidaldid-rte
changed the title
Extrapolation of getMinQ and getMaxQ for reactive capability curve
[WIP] Extrapolation of getMinQ and getMaxQ for reactive capability curve
Dec 11, 2024
vidaldid-rte
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but marked in WIP until we understand better whether this extrapolation is justified for usual groups.
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
This PR adresses this issue in Open Load Flow : powsybl/powsybl-open-loadflow#1143
What kind of change does this PR introduce?
For accuracy of load flow when generators are outside their active power limits (e.g for starting generators that may have P < Pmin). We want to model the reactive limits
getMinQ(p)
andgetMaxQ(p)
in a more accurate way than just getting the reactive power limits of the bound Pmin or Pmax. (See figure given in the linked issue)What is the current behavior?
When P < Pmin or P > Pmax, reactive limits of P :
getMinQ(P)
getMaxQ(P)
are the values ofgetMinQ(Pmin)
getMaxQ(Pmin)
(or Pmax).What is the new behavior (if this is a feature change)?
We introduce new methods
getMinQ(double p, boolean extrapolateReactiveLimitSlope)
(and same forgetMaxQ(...)
) that behaves like existinggetMinQ(double p)
if the boolean is set tofalse
. If set totrue
, the reactive limit slope of the PQ diagram is extrapolated outside active power limits (as shown in the figure given in the linked issue).Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
ReactiveCapabilityCurve API has been modified, introducing two methods :
getMinQ(double p, boolean extrapolateReactiveLimitSlope)
getMaxQ(double p, boolean extrapolateReactiveLimitSlope)
If
extrapolateReactiveLimitSlope = false
the behavior is the same as existinggetMinQ(p)
andgetMaxQ(p)
The method must be implemented by custom IIDM implementations.